IMO Commerce shouldn't directly reference the user/customer profile entity into the Order, but just add a detached copy of that (the profile address), so that it might be changed/edited in the Order backend independently (might be needed, after a Customer request ... or whatever), without the consequent update of the original profile, and its instances in different/other Orders ...
May be entity revisions, instead of entity reference (and complete detach), would be a good way to go, as already mentioned in this previous issue "Improve profile handling"
Comments
Comment #2
bojanz commentedYes, revisions are the plan, that's why we're using entity_reference_revisions for the billing_profile reference field.
Comment #3
bojanz commentedContinued in #3022850: [Addressbook, part 1] Rework the ownership model for customer profiles.