Arguments not working?

I have fixed this issue , it seems that its missed whie porting to D8 Version . working on patch will upload here soon.

Here is the patch that resolves the issue of argument passing to quicktabs and directly loading particular tab from the url.
to load particular tab use qt-quicktab instance name= tab number (e.g. www.mysite.com/?qt-mytab=1).

When I load a view with ajax that uses argument the patch #7 doesn't work. The reason is that current path is the path of the ajax route and we can’t use that for extracting the arguments we need. I have modified the patch to use $_SERVER[’HTTP_REFERER'] to get the arguments when ajax is used.

Improved the patch #10 to strip language prefixes in the url, allowing the use of the same offset with or without that language prefix.

$current_language = \Drupal::service('language_manager')->getCurrentLanguage()->getId();
$path = str_replace("/$current_language/", '/', $HTTP_REFERER['path']);

Fixing typo.

The patch works fine, but the first argument, like '333' in '/node/333' is matched to %2, because %0 is '' and %1 is 'node'. This is confusing and totally impossible to figure out from the docs until you look in the code and see the
$url_args = explode('/', $current_path);
Is it by design? Are there any real-life situations where the argument does not follow '/node/' or '/user/' or whatever, so that we can't just drop the first two elements?

This patch works great, thank you. Can we mark it RTBC?

Patch #12 works just fine.

+++ b/src/Plugin/TabType/ViewContent.php
@@ -73,6 +73,22 @@ class ViewContent extends TabTypeBase {
+        $HTTP_REFERER =  parse_url($_SERVER['HTTP_REFERER']);

Should we be using \Drupal::request()->server->get('HTTP_REFERER') instead?

I have rerolled the patch with the request service.

Since there are no tests covering this, I would appreciate anyone being able to test it against with their use cases.

Thank you @shelane for pushing this forward.

I wanted to note that any class extending ViewContent would have to be updated with this change, but I doubt anyone is doing so.

@@ -77,10 +102,13 @@ class ViewContent extends TabTypeBase {
       $current_path = \Drupal::service('path.current')->getPath();
       // If the request is a ajax callback we need to use $_SERVER['HTTP_REFERER'] to get current path.
       if (strpos($current_path, '/quicktabs/ajax/') !== FALSE) {
-        $HTTP_REFERER =  parse_url($_SERVER['HTTP_REFERER']);
+        $request = $this->requestStack->getCurrentRequest();
+        if ($request->server->get('HTTP_REFERER')) {
+          $referer = $request->server->get('HTTP_REFERER');
+        }
         // Stripping the language path prefix.
         $current_language = \Drupal::service('language_manager')->getCurrentLanguage()->getId();
-        $path = str_replace("/$current_language/", '/', $HTTP_REFERER['path']);
+        $path = str_replace("/$current_language/", '/', $referer);
         $current_path = \Drupal::service('path.alias_manager')->getPathByAlias($path);
       }
       $url_args = explode('/', $current_path);

Looks to me that it could be that $referer is not set which would result in a PHP Notice.

Ah yes. I meant to put a check in later for isset. Nice catch. I’ll update the patch shortly.

Here is a better refactor of that.

Patch in #22 does not apply to dev-3.x e8cae4a. Not sure why yet.

There have been significant code code changes with more to come. So, this is on my list to come back to after I get some other major issues fixed.

The patch didn't quite work for me without a few tweaks.
Here is what I had to do to get views tabs working with arguments.

Patch at 28 ignores all the changes for dependency injection from the previous patch. I'm going to have to manually review the differences.

Yea, I couldn't get the dependency injection working. That's where it was failing for me and no matter what I tried I couldn't get the dependencies to be available in the class. I'm probably overlooking something simple, as I'm still trying to wrap my head around how that all works in D8.

Patch 28 needs more work. When there is no QuickTabs yet created, this error is generated on the /admin/structure/quicktabs/add page:

Notice: Undefined index: type in Drupal\quicktabs\Plugin\TabType\ViewContent->optionsForm() (line 30 of modules/custom/quicktabs/src/Plugin/TabType/ViewContent.php).

This is what got views arguments working properly for me.