Fix coding standards and best practice in 7.x

There are currently 189 coding standards messages over the entire codebase at PHP5.3 and 196 messages at PHP5.4+

This patch fixes tests/scheduler.test, which I want to be clean before adding more tests. Because the entire file is checked and all infringements reported, having it clean before adding new tests makes it easier to check that the additons are compliant.

After scheduler.test the standards messages reduced to 145.
Here's a patch for scheduler.admin.inc

Intersting that one coding standards message "Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders" (Drupal.Semantics.FunctionT.ConcatString) is detected on d.o. running PHP5.3 but is allowed and not classed as a problem at PHP5.4+ (hence why it slipped through)

Down to 137 messages after fixing scheduler.admin.inc
Here's a patch for readme.txt, scheduler.api.php and scheduler.cron.inc

Down to 114 messages after fixing readme, api.php and cron.inc

Here's a patch for fixing .drush.inc, .edit.inc, .info and .install

Down to 102 now.
Here's a patch for .module

Down to 59 messages.
Patch for .rules.inc, rules_defaults.inc, tokens.inc and views.inc. Plus one 'drupal practice' fix for .install which was missed before.

Now only 28 messages left to fix.
Here's a patch for tests/scheduler_api.test and scheduler_handler_field_scheduler_countdown.inc (which also required a change in scheduler.views.inc).

This should be the last coding standards patch, but there may be one more for Drupal Practice. However, some of those suggestions may not be fixable.

Remaining coding standards messages: ZERO :-)

Here is a patch which fixes two of the three files with coding practice messages. As these are not reported in d.o. tests, the violations that this patch fixes are:

FILE: /Library/WebServer/Documents/drupal7/sites/all/modules/scheduler/scheduler.edit.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 1 LINE
---------------------------------------------------------------------------
 186 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible
 186 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible
---------------------------------------------------------------------------

and

FILE: /Library/WebServer/Documents/drupal7/sites/all/modules/scheduler/scheduler.tokens.inc
---------------------------------------------------------------------------
FOUND 0 ERRORS AND 8 WARNINGS AFFECTING 8 LINES
---------------------------------------------------------------------------
 57 | WARNING | Variable $publish_on is undefined.
 58 | WARNING | Variable $publish_on is undefined.
 63 | WARNING | Variable $unpublish_on is undefined.
 64 | WARNING | Variable $unpublish_on is undefined.
 75 | WARNING | Variable $publish_on is undefined.
 76 | WARNING | Variable $publish_on is undefined.
 78 | WARNING | Variable $unpublish_on is undefined.
 79 | WARNING | Variable $unpublish_on is undefined.
---------------------------------------------------------------------------

Thanks for pointing this out. My phpcs alias had a long list of --extensions but 'js' was missing, hence I never saw these.

Interestingly my version reports different fixes to yours. I have

 23 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
 38 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found

which yours did not fix. But the indentation and @see are not reported in my list.

1. Coder module on a 7.x site reports

   scheduler.edit.inc
   severity: normalreview: style_stdclassLine 30: use stdClass caseCapitalization, it's the one exception to the mixed case style standard [style_stdclass]
   $defaults = new StdClass();
   

2. scheduler_handler_field_scheduler_countdown.inc
   severity: minorreview: comment_comment_docblock_missingLine 51: Docblock should be immediately above SchedulerHandlerFieldSchedulerCountdown::option_definition (Drupal Docs) [comment_comment_docblock_missing]
   public function option_definition() {
   

3. scheduler.test
   severity: minorreview: comment_comment_see_inlineLine 606: @see should always be at the beginning of a line, never inline in other comments. (Drupal Docs) [comment_comment_see_inline]
   @see https://drupal.org/node/1614880
   

4. drupalcsp reports:

   FILE: /Library/WebServer/Documents/drupal7/sites/all/modules/scheduler/scheduler.admin.inc
   -----------------------------------------------------------------------------
   FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
   -----------------------------------------------------------------------------
    426 | WARNING | Do not use the raw $form_state['input'], use $form_state['values'] instead where possible
   -----------------------------------------------------------------------------
   

None of these are reported on d.o. testing.
Patch fixes 1 and 3 and sets to ignore 2 and 4.

7.x coding standards and best practices now have no warnings on d.o. testbot output, running coder 7.x-2.6 and using drupalcs and drupalcsp.

So I think we can close this issue as fixed.