When you press enter, the remaining message is discounting 2 characters instead 1. If I make a simple modification on js it only discounts 1.

CommentFileSizeAuthor
#9 Selection_011.png47.66 KBrpayanm
#2 key-enter-counter.patch424 bytesivan.chavarro

Comments

ivan.chavarro created an issue. See original summary.

ivan.chavarro’s picture

ivan.chavarro commented
StatusFileSize
new key-enter-counter.patch424 bytes
askibinski’s picture

askibinski commented
Status: Active » Reviewed & tested by the community

Looks good.

An enter is now counted as 1 char which seems logical.

Tested together with patch at #2804757: Truncate option makes CKEditor cursor endlessly blink in:

* Chrome 58
* IE11 / win8
* Edge 15 /win10
* Firefox 53 / win10
* Safari 10.1 / osx

mpp’s picture

mpp commented

Also RTBC, can this be committed please?

ralphvdhoudt’s picture

ralphvdhoudt commented

Patch works as advertised

dawehner’s picture

dawehner
Primary language German
commented
Status: Reviewed & tested by the community » Fixed

@askibinski Thanks so much for providing a good test coverage!
@ivan.chavarro Thank you for the patch

Thank you for providing the patch! I merged it and pushed it up

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
StatusFileSize
new Selection_011.png47.66 KB

I been tested this patch and it works fine but when you use character enter and I try to save I got this error:

Summary: may not be longer than 1000 characters.

alt