The LDAP users, which authenticate on a different system, are receiving email alerts about their password expiring. The authenticating system, which manages the password modification and expiration, causes the LDAP users to have their profiles grey-out their passwords, therefore, they cannot change them within the Drupal system.

CommentFileSizeAuthor
#12 interdiff-2872688-11-12.txt5.75 KBaohrvetpv
#12 password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-12.patch17.65 KBaohrvetpv
#11 password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-11.patch11.75 KBaohrvetpv
#10 password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-10.patch11.71 KBaohrvetpv
#7 password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-7.patch11.63 KBaohrvetpv
#6 password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-6.patch9.34 KBaohrvetpv
#2 password_policy-exclude_authmap_users-2872688-1.patch3.76 KBpetar.kolicov

Comments

petar.kolicov created an issue. See original summary.

petar.kolicov’s picture

petar.kolicov commented
StatusFileSize
new password_policy-exclude_authmap_users-2872688-1.patch3.76 KB

I added option 'Exclude authmap users' the option by default is disabled and in cron I add check if this option is enabled we exclude all authmap users.

aohrvetpv’s picture

aohrvetpv commented
Status: Active » Needs work

Thanks for the bug report and patch. Quick review:
- Variables defined by a module must be prefixed with the name of the module. So "password_policy_exclude..." Prevents name collisions.
- Patch seems to have some unrelated changes: a new XML file and an indentation change in unrelated code.

aohrvetpv’s picture

aohrvetpv commented

The approach in #1888366: Password Policy should optionally ignore users managed by other modules, used by 7.x-2.x, seems like it may be a better solution. It allows ignoring password policies for specific authentication modules, rather than all authmap users.

aohrvetpv’s picture

aohrvetpv commented
Assigned: petar.kolicov » aohrvetpv

I am developing a patch.

aohrvetpv’s picture

aohrvetpv commented
Version: 7.x-1.12 » 7.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-6.patch9.34 KB

Patch that allows excluding authentication modules on a per-policy basis.

A fieldset is added to the policy configuration form that allows specifying which authentication modules the policy should not be applied to.

The fieldset is added only when users exist on the site who authenticated with one or more external authentication modules. That is, if you do not use external authentication modules, the configuration form is the same as before.

Lacks automated tests. May adversely affect performance/caching--need to study more.

Please review/test!

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-7.patch11.63 KB

Previous patch was missing an added file.

The last submitted patch, 6: password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-6.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 7: password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-7.patch, failed testing.

aohrvetpv’s picture

aohrvetpv commented
Status: Needs work » Needs review
StatusFileSize
new password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-10.patch11.71 KB

Fixed PHPLint error (hopefully).

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-11.patch11.75 KB

Updated to apply on latest -dev code.

aohrvetpv’s picture

aohrvetpv commented
StatusFileSize
new password_policy-7.x-1.x-allow_excluding_authentication_modules-2872688-12.patch17.65 KB
new interdiff-2872688-11-12.txt5.75 KB

Added test case.

  • AohRveTPV committed cc79898 on 7.x-1.x 
    Issue #2872688 by AohRveTPV: Password Policy should optionally ignore...
aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.