Hi maintainers!
We had recently a discussion with Greg about the module and its structure, and i'd like to introduce a template file that makes it a bit easier managable for other modules and developers to change the look&feel of it that is currently pretty hard-coded and when a block tpl is created on a website, the developer needs to sanitize the variables before printing them out, that can cause open security issues on his/her sites.
Also in the attached patch i've cleaned up a bit the source code, removing totally the blocks.inc (basically replace it with the template file) and removed some documentation from header parts where drupal coding standard says it's enough to give point to the original hook that gets implemented.
Please review it and if you think it has value (or obviously need more love :)), let me know!
Cheers,
Balazs.

CommentFileSizeAuthor
#2 provide-tpl-and-some-cleanup-2871365-2.patch26.03 KBtatarbj
easy_breadcrumb_improvements.patch26.02 KBtatarbj

Comments

tatarbj created an issue. See original summary.

tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
StatusFileSize
new provide-tpl-and-some-cleanup-2871365-2.patch26.03 KB

I've just notice the math doesn't work and we always get an extra separator with the original patch, so fixing it, see my new patch (nothing else changed).

  • tatarbj committed 585945a on 7.x-2.x 
    Issue #2871365 by tatarbj: Provide tpl for the module and some clean-up
tatarbj’s picture

tatarbj
Primary language Hungarian
Location Brussels
commented
Status: Needs review » Fixed

After discussions with @Greg Boggs, i've committed in smaller commits the provided solution. Closing the issue as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.