In the latest release tag (7.x-2.0-beta4) the library definition for xmlseclibs has been removed, however it is still required as a dependency. This results in an error on the status report page. (See image.)

The removed code seems out of context for the commit, so I assume it is a mistake. I will make a patch to add the libraries definition again.

If the library is in fact no longer needed, then please inform me and I will make a patch to remove the code declaring the dependency requirement.

Comments

tss created an issue. See original summary.

tss’s picture

Added patch.

jrochate’s picture

ok, that fixes the message, but...

... on php-saml lib definition (saml_sp.module, line 267) the lib is already included.

Maybe the dependency should be simply removed as a lib, since it seams already included in php-saml as "2.0.0 modified" version.

jrglasgow’s picture

Status: Active » Fixed

I intentionally removed the library definition for xmlseclibs, but I forgot to remove the section of the requirements page. I have made that change.

victorlap@outlook.com’s picture

Can you also update the readme page? On there it still says to download the xmlseclibs

And maybe also remove the following code, it throws an error on the status page:

// xmlseclibs library
    $library = libraries_detect('xmlseclibs');
    $error_type = isset($library['error']) ? drupal_ucfirst($library['error']) : '';
    $error_message = isset($library['error message']) ? $library['error message'] : '';
    $library_name = $t($library['name']);

    if (empty($library['installed'])) {
      $requirements[$library['machine name']] = array(
        'title' => $library_name,
        'value' => $t('@e: At least @a', array('@e' => $error_type, '@a' => XMLSECLIBS_MIN_VERSION)),
        'severity' => REQUIREMENT_ERROR,
        'description' => $t('!error You need to download the !library, extract the archive and place the !machine_name directory in the %path directory on your server.', array('!error' => $error_message, '!library' => l($library_name, $library['download url']), '%path' => 'sites/all/libraries', '!machine_name' => $library['machine name'])),
      );
    }
    elseif (version_compare($library['version'], XMLSECLIBS_MIN_VERSION, '>=')) {
      $requirements[$library['machine name']] = array(
        'title' => $library_name,
        'severity' => REQUIREMENT_OK,
        'value' => $library['version'],
      );
    }
    else {
      $requirements[$library['machine name']] = array(
        'title' => $library_name,
        'value' => $t('At least @a', array('@a' => XMLSECLIBS_MIN_VERSION)),
        'severity' => REQUIREMENT_ERROR,
        'description' => $t('You need to download a later version of the !library and replace the old version located in the %path directory on your server.', array('!library' => l($library_name, $library['download url']), '%path' => $library['library path'])),
      );
    }

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.