Configure link can be added to the module in the .info.yml file so module can be easily configured after module is enabled.

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Assigned: Pavan B S » Unassigned
Status: Active » Needs review
StatusFileSize
new350 bytes

Applying the patch, please review.

dhruveshdtripathi’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new39.13 KB

Configure link added on Modules listing page. The link redirects to /admin/config/bibcite/settings

Good work!

antongp’s picture

Priority: Normal » Minor
StatusFileSize
new1.68 KB

Here is updated patch which adds Configure link to submodules as well.

  • kruhak committed 5cba3d9 on 8.x-1.x authored by antongp
    Issue #2870641 by Pavan B S, antongp, dhruveshdtripathi: No configure...
kruhak’s picture

Status: Reviewed & tested by the community » Fixed
dhruveshdtripathi’s picture

Hello @kruhak

You should give issue credit to the one who reviews the patch. Please provide issue credit.

Thank you

antongp’s picture

Hi @dhruveshdtripathi

We don't think that your patch review should be credited. Contributions credits are given for contribution to solving the issue i.e. for real help in solving it, or initial reporting about real issue with good description. So the issue author received a credit. We're glad to give credits for any real help in solving issues, but the problem here is that initial patch was (very) incomplete and then switched to Reviewed & tested by the community while the patch obviously required for updates / additional work. This also confused maintainers since they expect that patch is good or close to it with the Reviewed & tested by the community status, but this is not true in this case.

Thank you for understanding.

dhruveshdtripathi’s picture

Got your point.

Thank you

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.