Closed (fixed)
Project:
Bibliography & Citation
Version:
8.x-1.x-dev
Component:
Code
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Apr 2017 at 10:53 UTC
Updated:
10 May 2017 at 08:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
Pavan B S commentedApplying the patch, please review.
Comment #3
dhruveshdtripathi commentedConfigure link added on Modules listing page. The link redirects to /admin/config/bibcite/settings
Good work!
Comment #4
antongp commentedHere is updated patch which adds Configure link to submodules as well.
Comment #6
kruhak commentedComment #7
dhruveshdtripathi commentedHello @kruhak
You should give issue credit to the one who reviews the patch. Please provide issue credit.
Thank you
Comment #8
antongp commentedHi @dhruveshdtripathi
We don't think that your patch review should be credited. Contributions credits are given for contribution to solving the issue i.e. for real help in solving it, or initial reporting about real issue with good description. So the issue author received a credit. We're glad to give credits for any real help in solving issues, but the problem here is that initial patch was (very) incomplete and then switched to Reviewed & tested by the community while the patch obviously required for updates / additional work. This also confused maintainers since they expect that patch is good or close to it with the Reviewed & tested by the community status, but this is not true in this case.
Thank you for understanding.
Comment #9
dhruveshdtripathi commentedGot your point.
Thank you