On our site, we have a select list of external links that we want to place a rel="follow" on, but would want the rest of the external links to get nofollow added automatically via the module.

CommentFileSizeAuthor
#10 interdiff-6-10.txt150 bytesprashant.c
#10 config_follow_no_override-2870492-10.patch4.76 KBprashant.c
#6 interdiff-2-6.txt10.23 KBprashant.c
#6 config_follow_no_override-2870492-6.patch4.76 KBprashant.c
#2 config_follow_no_override-2870492-2.patch10.49 KBAnonymous (not verified)

Comments

Anonymous’s picture

Anonymous (not verified) commented

rsmylski created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new config_follow_no_override-2870492-2.patch10.49 KB

I've created a patch to add this functionality.

elachlan’s picture

elachlan commented

If you can re-roll it I'll add it in.

elachlan’s picture

elachlan commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: config_follow_no_override-2870492-2.patch, failed testing. View results

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Needs work » Needs review
StatusFileSize
new config_follow_no_override-2870492-6.patch4.76 KB
new interdiff-2-6.txt10.23 KB

@elachlan
Re-rolling the patch but i could not figure out what changes #2 has made in extlink.min.js. So adding without without changing the extlink.min.js file.

@elachlan if you can figure out what needs to changed in min file as well i will add the same in the patch as well.

Thanks.

Status: Needs review » Needs work

The last submitted patch, 6: config_follow_no_override-2870492-6.patch, failed testing. View results

elachlan’s picture

elachlan commented

The min js was removed in #2929552: Remove minified js file

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented

@elachlan

I don't know why the test is throwing the error for 

There was 1 error:

1) Drupal\Tests\extlink\FunctionalJavascript\ExtlinkTest::testExtlink
Drupal\Core\Config\Schema\SchemaIncompleteException: Schema errors for extlink.settings with the following errors: extlink.settings:extlink_follow_no_override variable type is integer but applied schema class is Drupal\Core\TypedData\Plugin\DataType\BooleanData

As the field "extlink_follow_no_override" is defined as Boolean in schema file and also as checkbox type in 

ExtlinkAdminSettingsForm.php

file.

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Needs work » Needs review
StatusFileSize
new config_follow_no_override-2870492-10.patch4.76 KB
new interdiff-6-10.txt150 bytes

I think i got it the error was due to the integer value in 

config/install/extlink.settings.yml

Re-submitting the patch.

  • elachlan committed 2098d61 on 8.x-1.x authored by Prashant.c 
    Issue #2870492 by Prashant.c, rsmylski: Allow rel="follow" to not be...
elachlan’s picture

elachlan commented
Status: Needs review » Fixed
Related issues: +#2961572: Expand Javascript Functional Tests

Committed. Thanks for your work.

We will add tests for it in #2961572: Expand Javascript Functional Tests.

  • elachlan committed 7eeb194 on 8.x-1.x 
    Issue #2870492 by Prashant.c, rsmylski, elachlan: Allow rel="follow" to...
elachlan’s picture

elachlan commented

I found a small issue while testing.

  • elachlan committed 4428703 on 8.x-1.x 
    Issue #2870492 by Prashant.c, rsmylski, elachlan: Allow rel="follow" to...

  • elachlan committed 8966729 on 8.x-1.x 
    Issue #2870492 by Prashant.c, rsmylski, elachlan: Allow rel="follow" to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.