The methods getFlagMessage() / getUnflagMessage() aren't called from anywhere other than the flag form.

So we have these properties on flags and we never make use of them!

The message should be output using dsm() after a user uses a flag link with a form or a reload; for JS links there is already an issue: #2764709: [Regression/Refactor] Restore Ajax link type "flag message" functionality.

Comments

joachim created an issue. See original summary.

martin107’s picture

martin107 commented
Related issues: +#2868098: refactor all get(un)Flag*() methods

Just wanted to mention a relevant side issue when it comes to committing, and conflicts.

getFlagMessage() / getUnflagMessage() are being merge here

joachim’s picture

joachim commented
Related issues: -#2868098: refactor all get(un)Flag*() methods

That issue's now committed, so removing it from the related list.

maaty388’s picture

maaty388 commented
Status: Active » Closed (won't fix)

Closing issue