This module stores sensitive data in (base64 encoded) plaintext including passwords and URIs containing a password. For security compliancy this is simply not an option especially on enterprise sites.

CommentFileSizeAuthor
#13 2869597-13.patch15.16 KBtimmillwood
#10 2869597-10.patch15.39 KBtimmillwood
#7 2869597-7.patch170.79 KBtimmillwood
#6 2869597-6.patch170.72 KBtimmillwood
#6 interdiff-2869597-6.txt2.77 KBtimmillwood
#4 relaxed-2869597-4.patch12.57 KBjribeiro
#2 relaxed-2869597-2.patch12.56 KBbadjava
#2 relaxed-2869597-2.patch12.56 KBbadjava

Comments

badjava created an issue. See original summary.

badjava’s picture

badjava commented
Status: Active » Needs review
StatusFileSize
new relaxed-2869597-2.patch12.56 KB
new relaxed-2869597-2.patch12.56 KB

Here is an attempt at a patch that adds optional encryption support using a new service relaxed.sensitive_data.transformer.

badjava’s picture

badjava commented
jribeiro’s picture

jribeiro commented
StatusFileSize
new relaxed-2869597-4.patch12.57 KB

Rerolling patch.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Needs work
Issue tags: +Needs tests

Looks good, I like that it's an optional dependency on Encrypt module, however because it "works" without encrypt this means it's not covered by any of the existing tests, so we'll need specific encrypt tests.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
Issue tags: -Needs tests
StatusFileSize
new interdiff-2869597-6.txt2.77 KB
new 2869597-6.patch170.72 KB

Adding a simple encrypt test.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
StatusFileSize
new 2869597-7.patch170.79 KB

Adding docblock to test.

The last submitted patch, 6: 2869597-6.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 7: 2869597-7.patch, failed testing. View results

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2869597-10.patch15.39 KB

Helps if I patch the correct branch!!

Status: Needs review » Needs work

The last submitted patch, 10: 2869597-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • timmillwood committed 10b3cca on 8.x-1.x authored by badjava 
    Issue #2869597 by timmillwood, badjava, jribeiro: Add encryption support...
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2869597-13.patch15.16 KB

Committed the info file changes only so testbot knows the correct test dependencies.

  • timmillwood committed 563a4a7 on 8.x-1.x authored by badjava 
    Issue #2869597 by timmillwood, badjava, jribeiro: Add encryption support...
timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Fixed

Great, it's now passing, so I've pushed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.