PHP 7.1 introduced warnings about invalid strings in arithmetic. Memory limit calculation in MigrationBase constructor is performing multiplication on non-numeric string (e.g. 128M) which causes the following notice to be reported:

Notice: A non well formed numeric value encountered in MigrationBase->__construct() (line 425 of .../sites/all/modules/contrib/migrate/includes/base.inc).

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vaish created an issue. See original summary.

vaish’s picture

This patch strips non-numeric character from the memory limit value before arithmetic calculations are performed on it.

vaish’s picture

Status: Active » Needs review
vaish’s picture

Issue tags: +PHP 7.1
camerongreen’s picture

Having the same issue, and this patch fixes it.

oadaeh’s picture

Status: Needs review » Reviewed & tested by the community

The patch in #2 works for me, too.

applicity_sam’s picture

Patch in #2 works for me.

jcisio’s picture

RTBC again. Trivial patch.

  • pifagor committed 91f601b on 7.x-2.x
    Issue #2635792 by nedjo, hanoii: SQLSTATE[22007]: Invalid datetime...
pifagor’s picture

Status: Reviewed & tested by the community » Fixed
pifagor’s picture

Status: Fixed » Closed (fixed)
oadaeh’s picture

@pifagor testing and reviewing patches are contributions, too.

pifagor’s picture

Sure. Sorry, i copied text here - "Git command".

oadaeh’s picture

You should only need to check the boxes next to the names under "Commit message" of those who helped and Save to update the contributions. It will update the message in "Git command," but it won't affect the actual commit message.

pifagor’s picture

Thank, you!

oadaeh’s picture

Будь ласка.

heddn’s picture

No need to move things into closed (fixed) status. The issue queue will do that after 2 weeks after an issue is marked fixed.