I've installed the module on Drupal 8.3.0. It works pretty good but found an issue.

When I launch something on the backoffice (generate path alias for instance) that needs a batch, Drupal throws me a "page not found".

I noticed that it is the processInbound function which causes this error. In fact, the path given in argument is modified in every case which we might not want.

Patch is coming

CommentFileSizeAuthor
#13 2868319-13.patch604 bytesokin
#6 2868319-6.patch2.27 KBmartins.bertins
#6 interdiff-2868319-5-6.txt1011 bytesmartins.bertins
#5 2868319-5.patch2.06 KBmartins.bertins
#5 interdiff-2868319-4-5.txt1.29 KBmartins.bertins
#4 page-not-found-2868319-4.patch1.41 KBimyaro
#3 page-not-found-2868319-3.patch1.33 KBkala4ek
#2 page-not-found-2868319-2.patch958 bytesgarnett2125

Comments

garnett2125 created an issue. See original summary.

garnett2125’s picture

garnett2125 commented
StatusFileSize
new page-not-found-2868319-2.patch958 bytes
kala4ek’s picture

kala4ek
Primary language Russian
Location 🇷🇺 Novosibirsk
commented
StatusFileSize
new page-not-found-2868319-3.patch1.33 KB

The patch does not work for me.

$source = $this->aliasManager->getPathByAlias($candidate_alias)
$source will always contains smth. It may be source path, if it exist or it may be alias. See description of getPathByAlias method.

I rewrite the path and it works for me.

imyaro’s picture

imyaro commented
Assigned: garnett2125 » Unassigned
StatusFileSize
new page-not-found-2868319-4.patch1.41 KB

Hello,
Guys, thanks for your patches, but it isn't work if we have, for example, one node that has path "foo" and another "foo/bar"
In this way node with alias "foo" will be found and URL for second one will be /node/1/bar (instead of the /node/2)
I have changed a search "direction" it works better now.

martins.bertins’s picture

martins.bertins commented
StatusFileSize
new interdiff-2868319-4-5.txt1.29 KB
new 2868319-5.patch2.06 KB

Found a scenario where the processInbound() function returned incorrect path for standard taxonomy term path taxonomy/term/{taxonomy_term} (this might apply for any entity). Added a fix for this.
Also the processOutbound() function must take into account language code when looking for path alias.

martins.bertins’s picture

martins.bertins commented
StatusFileSize
new interdiff-2868319-5-6.txt1011 bytes
new 2868319-6.patch2.27 KB

Added validation for path.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs review » Fixed

Thanks @fellows for the patch

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

okin’s picture

okin commented

The validation of the path should validate the path regardless the current user has access to it or not. Otherwise a not found is triggered and not an access denied.

\Drupal::service('path.validator')->getUrlIfValidWithoutAccessCheck($return_path)

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

@okin can you provide a patch for this?

okin’s picture

okin commented
StatusFileSize
new 2868319-13.patch604 bytes

Here it is

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

Thank @okin the patch was applied it should be shown here in the next minutes I think.