Problem/Motivation

Implement Bootstrap pagination component.

Remaining tasks

  • Override needed template file and add needed HTML/CSS, more info https://v4-alpha.getbootstrap.com/components/pagination/
  • If pagination CSS from BS is missing add it as SASS partial in components folder, add library definition and then include that library in template override.
  • Check and update starterkit_bootstrap if needed.
CommentFileSizeAuthor
#7 interdiff-2868084-7.txt871 bytesthenchev
#7 add_bs_pager_pagination-2868084-7.patch11.44 KBthenchev
#5 interdiff-2868084-5.txt5.09 KBthenchev
#5 add_bs_pager_pagination-2868084-5.patch12.29 KBthenchev
#4 pagination-2868084-4.patch11.58 KBthenchev
#4 dots.png1.64 KBthenchev
#4 mini.png4.19 KBthenchev
#4 2.png5.71 KBthenchev
#4 1.png7.08 KBthenchev

Comments

pivica created an issue. See original summary.

pivica’s picture

pivica commented
Issue summary: View changes
thenchev’s picture

thenchev commented
Assigned: Unassigned » thenchev
thenchev’s picture

thenchev commented
Status: Active » Needs review
StatusFileSize
new 1.png7.08 KB
new 2.png5.71 KB
new mini.png4.19 KB
new dots.png1.64 KB
new pagination-2868084-4.patch11.58 KB

1. In pager.html.twig and views-mini-pager.html.twig the aria-label in I set to "Pagination". We need to set a label for the pager like 'search results' or 'node listing'. There is no way to do that without creating some preprocess and adding some value. I can check how other themes do that...

2. Drupal hides for example <

In bootstrap we have the .disabled class. Couldn't find any research on this but maybe we want to just disable not hide. Just a note, don't think this is too important.

3. Drupal has '...' currently its black because of

a:not([href]):not([tabindex]) {
  color: inherit;
  text-decoration: none;
}

when I remove color: inherit; it looks ok. Do we need this color: inherit; ?

4. Had to fix gulp-options the path prevented me from generating css in starterkit. Also im for removing contrib in path so it's:
'../../../bs_base/' and check other places where we depend on this folder structure.

Here is btw how minipager looks:

thenchev’s picture

thenchev commented
StatusFileSize
new add_bs_pager_pagination-2868084-5.patch12.29 KB
new interdiff-2868084-5.txt5.09 KB

Updated patch, now it works with ajax enabled.

pivica’s picture

pivica commented
Status: Needs review » Needs work 
+++ b/themes/starterkit_bootstrap/gulp-options.yml
@@ -10,15 +10,15 @@ parentTheme:
-    path: '../../contrib/bs_base/themes/bs_bootstrap/'
+    path: '../../../../contrib/bs_base/themes/bs_bootstrap/'

This change here is problematic. Check #2875257-8: Add BS modal support and #2875257-10: Add BS modal support comments.

The rest looks good.

thenchev’s picture

thenchev commented
Status: Needs work » Needs review
StatusFileSize
new add_bs_pager_pagination-2868084-7.patch11.44 KB
new interdiff-2868084-7.txt871 bytes

Checked the other issue, makes sense. Here's the update.

  • pivica committed 56f0f91 on 8.x-1.x authored by Denchev 
    Issue #2868084 by Denchev: Add BS pager/pagination
pivica’s picture

pivica commented
Status: Needs review » Fixed

Thx, commited.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.