ConnectionUnitTest::testConnectionOpen fails if the driver is not implementing a PDO connection

Thanks all!

With regards to

makes things easier for people implementing alternate db drivers

there are a few more issues that would need some love in this sense, if anybody feels like giving a hand :)

See #2605284: Testing framework does not work with contributed database drivers and related issues.

Actually, please revert this - in the process of creating new versions of the patch, the $this->markTestSkipped moved down in the method and now it's too late to avoid the error:

  /**
   * Tests pdo options override.
   */
  public function testConnectionOpen() {
    $connection = Database::getConnection('default');
    $reflection = new \ReflectionObject($connection);
    $connection_property = $reflection->getProperty('connection');
    $connection_property->setAccessible(TRUE);
    $error_mode = $connection_property->getValue($connection)
      ->getAttribute(\PDO::ATTR_ERRMODE);
    $this->assertEqual($error_mode, \PDO::ERRMODE_EXCEPTION, 'Ensure the default error mode is set to exception.');

    $connection = Database::getConnectionInfo('default');
    $connection['default']['pdo'][\PDO::ATTR_ERRMODE] = \PDO::ERRMODE_SILENT;
    Database::addConnectionInfo('test', 'default', $connection['default']);
    $connection = Database::getConnection('default', 'test');

    $reflection = new \ReflectionObject($connection);
    $connection_property = $reflection->getProperty('connection');
    $connection_property->setAccessible(TRUE);
    // Skip this test when a database driver does not implement PDO.
    // An alternative database driver that does not implement PDO
    // should implement its own connection test."
    if (get_class($connection_property->getValue($connection)) !== 'PDO') {
      $this->markTestSkipped('Ignored PDO connection unit test for this driver because it does not implement PDO.');
    }
    $error_mode = $connection_property->getValue($connection)
      ->getAttribute(\PDO::ATTR_ERRMODE);
    $this->assertEqual($error_mode, \PDO::ERRMODE_SILENT, 'Ensure PDO connection options can be overridden.');

    Database::removeConnection('test');
  }

it should be just after the first 'setAccessible' as it was in the patch in #2.

Thanks!

+++ b/core/tests/Drupal/KernelTests/Core/Database/ConnectionUnitTest.php
@@ -221,6 +221,12 @@ public function testConnectionOpen() {
+    // should implement its own connection test."

Ending quote can be removed on commit, I think :)

Sorry for being nitpicky :(

Good to go for me when it turns back green. Tested #28 with an alternative db driver, works OK.

Running PHPUnit kernel tests for an alternative db driver that does not implement PDO connection:

Without the patch in #28 applied:

$ ../vendor/bin/phpunit --testsuite kernel --group Database,Cache --verbose
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.
Runtime:	PHP 7.0.17
Configuration:	/home/travis/drupal8/core/phpunit.xml.dist
...............................................................  63 / 251 ( 25%)
.................................E............................. 126 / 251 ( 50%)
............................................................... 189 / 251 ( 75%)
..............................................................
Time: 8.03 minutes, Memory: 58.00MB
There was 1 error:
1) Drupal\KernelTests\Core\Database\ConnectionUnitTest::testConnectionOpen
Error: Call to undefined method Doctrine\DBAL\Connection::getAttribute()
/home/travis/drupal8/core/tests/Drupal/KernelTests/Core/Database/ConnectionUnitTest.php:225

With the patch in #28 applied:

$ ../vendor/bin/phpunit --testsuite kernel --group Database,Cache --verbose
PHPUnit 4.8.35 by Sebastian Bergmann and contributors.
Runtime:	PHP 7.0.17
Configuration:	/home/travis/drupal8/core/phpunit.xml.dist
...............................................................  63 / 251 ( 25%)
............................................................... 126 / 251 ( 50%)
............................................................... 189 / 251 ( 75%)
....................S.........................................
Time: 6.52 minutes, Memory: 58.00MB
There was 1 skipped test:
1) Drupal\KernelTests\Core\Database\ConnectionUnitTest::testConnectionOpen
Ignored PDO connection unit test for this driver because it does not implement PDO.
/home/travis/drupal8/core/tests/Drupal/KernelTests/Core/Database/ConnectionUnitTest.php:228