The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.There are some minor errors in the code base
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | edit_fix_coding_standards-2867646-12.patch.txt | 545 bytes | walangitan |
| #8 | fix_coding_standards-2867646-8.patch | 5.87 KB | adamzimmermann |
| #4 | fix_coding_standards-2867646-4.patch | 6.09 KB | adamzimmermann |
| #2 | 2867646-2.patch | 4.06 KB | Pavan B S |
Comments
Comment #2
Pavan B S commentedApplying the patch, please review
Comment #3
Pavan B S commentedComment #4
adamzimmermann commentedComment #5
adamzimmermann commentedMost of the changes look good, but there were two spots were
check_plain()was called on text that would have HTML in it. I reverted those back to calls tot(). If we want to change the placeholders to something more secure than!to@we could do that.While I was at it, I made a couple other code standards fixes. Check it out and see if this addresses your original concerns.
Comment #6
Pavan B S commented@adamzimmermann thank you for the suggestions
Comment #7
markdorison@adamzimmermann Did you mean to include the binary file in the #4 patch? I think it is unrelated.
Comment #8
adamzimmermann commentedGood catch. Remnants of old patches! Removed and new patch attached.
Comment #9
adamzimmermann commentedComment #11
markdorisonComment #12
walangitan commentedI have observed a
as a result of
apikeynot being camel cased which appears to cause issues with the recurly php library recognizing the property. This patch should resolve this regression.Comment #13
adamzimmermann commentedLooks good to me. Sometimes we can't follow all the coding standards it seems.
Comment #15
markdorisonThis rings a bell for me; great catch.
Comment #17
markdorisonCommitted the wrong patched; fixed.