assertEqual() is deprecated in Drupal 9. Replace with assertEquals()

Hi Pavan B S,

Thank you for the patch. However, the link you give is to the AssertContent trait. Could you give a link to the coding standard you mention, and show exactly which methods/classes are now deprecated.

Jonathan

[edit: I've now fixed the links in the issue summary]

The original patch had several changes to assert functions but the patch in #4 just concentrates on replacing AssertEqual() with AssertEquals() so we will keep this issue to address that single task.

Old: assertEqual($actual, $expected, $message = '')

New: assertEquals($expected, $actual, $message = '', $delta = 0.0, $maxDepth = 10, $canonicalize = FALSE, $ignoreCase = FALSE)

Note that the first two parameters need to be swapped around.

Linked to parent issue.

Note that this is not currently (at 8.7.x or 8.6.10) producing any deprecation warnings during testing.

The core issue #3031580: Undeprecate \Drupal\FunctionalTests\AssertLegacyTrait and \Drupal\KernelTests\AssertLegacyTrait in Drupal 8 removed the deprecation warnings from FunctionalTests/AssertLegacyTrait.php and /KernelTests/AssertLegacyTrait.php so that is why we do not see them in test output.

Looks like AssertEqual() is not going to be deprecated until Drupal 9 and won't be disappearing until Drupal 10.

Updated title and issue summary. We can still work on this now, though.

The patch in #4 from April 2017 only changed three test files. API, Multilingual and Tokens. assertEqual() is used in five other tests: Admin, DefaultTime, Devel, PastDates and Revisioning. Some of these have been added since the the patch was created. Here's a patch for all eight tests affected.

Note that with new syntax the expected value comes first, then the actual tested value. In the Revisioning test, we had a 4th parameter $group, which is not required (never was really)

Committed.
Thanks Pavan B S for starting off this correction.