In Issue https://www.drupal.org/node/2451657 @dawehner pointed out that the patch of getValue is a separate issue. Calling getValue on the EntityField does not always return the translation that is selected by the result row.

CommentFileSizeAuthor
#3 entityfield_getvalue-2866067-3.patch2.15 KBk4v
#2 entityfield_getvalue-2866067-2--testonly.patch1005 bytesk4v

Comments

k4v created an issue. See original summary.

k4v’s picture

k4v commented
StatusFileSize
new entityfield_getvalue-2866067-2--testonly.patch1005 bytes

I modified the RowEntityRendersTest to also check getValue on the entity field. Here is the test only patch.

k4v’s picture

k4v commented
StatusFileSize
new entityfield_getvalue-2866067-3.patch2.15 KB

This is the change on EntityField from https://www.drupal.org/node/2451657 and the new test. Still fails...

k4v’s picture

k4v commented
Status: Active » Needs review

The last submitted patch, 2: entityfield_getvalue-2866067-2--testonly.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 3: entityfield_getvalue-2866067-3.patch, failed testing.

k4v’s picture

k4v commented

Did some more research on this. The test fails for the TranslationLanguageRenderer, where the View is configured to output the selected translation of the row.

Drupal\views\Entity\Render\TranslationLanguageRenderer::getLancode() returns the default Language, because $this->langcodeAlias is NULL.

k4v’s picture

k4v commented

So that's because we did not call query() before... The langcode we are looking for is stored with the key of the table column alias (e.g. 'node_field_data_langcode). No idea how to fix this here.

k4v’s picture

k4v commented
Assigned: k4v » Unassigned

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)
Issue tags: +Bug Smash Initiative

This was fixed in 8.4.x in #2451657: Views should not condition joins on the langcode of fields that are not translatable

Closing as outdated.