I believe backtick and tilde should count as symbols. These seem to be the only symbols on my keyboard not counted as such.

CommentFileSizeAuthor
#4 interidff-2865506-2-4.txt976 bytesl0ke
#4 password_policy-7.x-2.x-add_tilde_and_backtick_to_symbol_count-2865506-4.patch1.75 KBl0ke
#2 password_policy-7.x-2.x-add_tilde_and_backtick_to_symbol_count-2865506-2.patch1.4 KBaohrvetpv

Comments

AohRveTPV created an issue. See original summary.

aohrvetpv’s picture

aohrvetpv commented
Status: Active » Needs review
StatusFileSize
new password_policy-7.x-2.x-add_tilde_and_backtick_to_symbol_count-2865506-2.patch1.4 KB
aohrvetpv’s picture

aohrvetpv commented
Title: Symbol count constraint does not count tilde and backtick » Symbol count constraint does not count backtick and tilde
Issue summary: View changes
l0ke’s picture

l0ke
Primary language English
Location Ukraine
commented
StatusFileSize
new password_policy-7.x-2.x-add_tilde_and_backtick_to_symbol_count-2865506-4.patch1.75 KB
new interidff-2865506-2-4.txt976 bytes

You missed second string in password_policy.test
And updating symbol_count.inc string to be consistent.

aohrvetpv’s picture

aohrvetpv commented

Re: the inconsistent symbols string: I tested and it looks like there was no functional consequence to that inconsistency. Backslash is still counted as a symbol. preg_quote() in symbol_count.inc may escape the symbols. So I'm wondering if using \\ causes a problem--it may cause the backslash to be escaped twice.

aohrvetpv’s picture

aohrvetpv commented

I was confused in #5. There is no functional difference between using \ versus \\. So we might as well be consistent and use \\ in all cases, as you did in #4.

aohrvetpv’s picture

aohrvetpv commented
Status: Needs review » Reviewed & tested by the community

  • AohRveTPV committed 7141e75 on 7.x-2.x 
    Issue #2865506 by l0ke, AohRveTPV: Symbol count constraint does not...
aohrvetpv’s picture

aohrvetpv commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.