Closed (fixed)
Project:
Automated Logout
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Mar 2017 at 10:45 UTC
Updated:
28 Mar 2020 at 19:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
deadbeef commentedComment #4
deadbeef commentedUpdated to include missed comfig schema
Comment #6
deaom commentedRe-rolled the patch so now it applies to dev branch and it seems to be working. When you add the Role timeout, you get the additional option of adding a redirect url at logout. The only problem is, that it can't be empty. If you leave it empty whole site comes crashing down. So it either needs to be a required field or default redirect url needs to be set if the role specific one is not set. So leaving it's status at needs work.
Comment #7
bcizej commentedI added the setting to automated tests to get them passing again. I fixed the website errors on empty fields by adding a validation on the setting if it is not empty and if the setting is empty it will take the default redirect URL setting.
Comment #8
bcizej commentedCoding standards fixes.
Comment #9
bcizej commentedComment #10
deaom commentedThanks @benjamincizej for the updated tests and adding a validation. The patch applies and works so marking it as RTBC.
Comment #12
boshtian commented