Our project logs-in different roles with different methods and different workflows. Patch to follow allows specification of a per-role logout URL.

Comments

deadbeef created an issue. See original summary.

deadbeef’s picture

Status: Active » Needs review
StatusFileSize
new6.75 KB

Status: Needs review » Needs work

The last submitted patch, 2: per-role-logout-2864998-1.patch, failed testing.

deadbeef’s picture

Status: Needs work » Needs review
StatusFileSize
new7.16 KB

Updated to include missed comfig schema

Status: Needs review » Needs work

The last submitted patch, 4: per-role-logout-2864998-3.patch, failed testing.

deaom’s picture

StatusFileSize
new5.09 KB

Re-rolled the patch so now it applies to dev branch and it seems to be working. When you add the Role timeout, you get the additional option of adding a redirect url at logout. The only problem is, that it can't be empty. If you leave it empty whole site comes crashing down. So it either needs to be a required field or default redirect url needs to be set if the role specific one is not set. So leaving it's status at needs work.

bcizej’s picture

StatusFileSize
new8.87 KB
new4.42 KB

I added the setting to automated tests to get them passing again. I fixed the website errors on empty fields by adding a validation on the setting if it is not empty and if the setting is empty it will take the default redirect URL setting.

bcizej’s picture

StatusFileSize
new10.75 KB
new3.7 KB

Coding standards fixes.

bcizej’s picture

Status: Needs work » Needs review
deaom’s picture

Status: Needs review » Reviewed & tested by the community

Thanks @benjamincizej for the updated tests and adding a validation. The patch applies and works so marking it as RTBC.

boshtian’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.