Content moderation form doesn't appear on new entities

1. +++ b/core/modules/content_moderation/src/EntityOperations.php
   @@ -234,8 +234,7 @@ public function entityView(array &$build, EntityInterface $entity, EntityViewDis
   -    if ($entity->isDefaultRevision()) {
   +    if ($this->moderationInfo->isLiveRevision($entity)) {
   

   A "live" entity revision is one whose latest revision is also the default, and whose moderation state, if any, is a published state.

   The docblock on this method would indicate this change makes total sense. Nice.

2. +++ b/core/modules/content_moderation/src/Tests/ModerationFormTest.php
   @@ -43,6 +43,12 @@ public function testModerationForm() {
   +    // The published view should have a moderation form, because it is not the
   +    // live revision.
   

   Maybe the comment shouldn't use "published view" because the case we are fixing is specifically a draft, unpublished revision. Maybe "canonical view" is better given the variable name.

3. +++ b/core/modules/content_moderation/src/Tests/ModerationFormTest.php
   @@ -43,6 +43,12 @@ public function testModerationForm() {
   +    $this->assertText('Status', 'The node view page has a moderation form.');
   
   @@ -53,6 +59,12 @@ public function testModerationForm() {
   +    $this->assertText('Status', 'The node view page has a moderation form.');
   

   Maybe ::assertField would be a better assertion for if the moderation form exists or not. "Status" feels like it could drift into false positive territory.

Manual testing looks good. I don't think this needs a usability review as it's a bug fix that makes things more consistent. Amended workflow looks like:

Brand new article in a draft state:

After it has been published:

Once it's back in a draft state:

I like it, looks good.

Not sure what is the best direction #2815921: Allow to use the EntityModerationForm on non forward revision pages

At least from a user point of view being able to see it on draft only content totally makes sense.

Just comparing the patch here and the patch in #2815921: Allow to use the EntityModerationForm on non forward revision pages, I think this is a better implementation.

Having also reviewed both of these patches again, I think they are functionally exactly the same. The reason being, for any revision with a published state we also force that revision to be the default revision.

Hence I believe:

$this->moderationInfo->getWorkflowForEntity($entity)->getState($entity->moderation_state->value)->isPublishedState()

will have the exact same outcomes as:

$this->moderationInfo->isLiveRevision($entity)

@timmillwood pointed me here from #2870484: No way to moderate content that hasn't been published already.

I tested this approach, and while it addresses the issue of new content, it doesn't allow for moderating content out of a published state (which might only apply to advanced workflows).

Needs a reroll.

Here's the reroll.

Committed/pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!

I thought about the case in #16, but I think that's a behaviour change/feature as opposed to a bug fix (which I agree this is).

I've added #2875843: Display content moderation form on published revisions as a follow-up, and marked #2870484: No way to moderate content that hasn't been published already as a duplicate of this.