Problem/Motivation

This module supports Views Bulk Operations (VBO) actions. In the VBO action confirmation page, target entities are listed but each item in the list is empty. See the image below:

Capture

Steps to reproduce:

  1. Install the module better_watchdog_ui.
  2. Open the log list page /admin/reports/dblog.
  3. Check some items in the table and click the button "Clear selected messages".
  4. The confirmation pages is displayed and you can see the list items are empty.

Proposed resolution

The cause is the place where the "label callback" is defined.

The label callback of the entity better_watchdog_ui_watchdog is better_watchdog_ui_watchdog_title(). It is defined in an inc file better_watchdog_ui_entity.pages.inc but it's not always loaded when it's necessary.

Moving it to better_watchdog_ui_entity.module fixes the issue.

Remaining tasks

  • Create a patch.
  • Review the patch.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 better_watchdog_ui-display_label-2864334-2.patch1.27 KBhgoto
#2 2864334-2.png115.24 KBhgoto

Comments

hgoto created an issue. See original summary.

hgoto’s picture

hgoto commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new 2864334-2.png115.24 KB
new better_watchdog_ui-display_label-2864334-2.patch1.27 KB

Here is a capture and a patch. I'd like someone to review this.

hgoto’s picture

hgoto commented

To test the patch, the following issue should be addressed in advance.

#2856723: Clear selected log messages not working with VBO 3.4

  • hgoto committed 17e5cd2 on 7.x-3.x 
    Issue #2864334 by hgoto: Labels for entities are not displayed properly...
c_lehel’s picture

c_lehel commented
Status: Needs review » Fixed
c_lehel’s picture

c_lehel commented
Status: Fixed » Closed (fixed)