EntityManager has been split into 11 classes. So now EntityManager and EntityManagerInterface are deprecated.

CommentFileSizeAuthor
#8 interdiff-2864259-7-8.txt7.58 KBsutharsan
#8 fieldblock_entity_manager_2864259_8.patch14.24 KBsutharsan
#7 fieldblock_entity_manager_2864259_7.patch12.88 KBsutharsan
#5 fieldblock_interdiff_2_5.txt3.59 KBnkoporec
#5 fieldblock_entity_manager_2864259_5.patch13.27 KBnkoporec
#2 2864259-2.patch12.65 KBPavan B S

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Assigned: Pavan B S » Unassigned
Status: Active » Needs review
StatusFileSize
new 2864259-2.patch12.65 KB

Applying the patch, please review.

socialnicheguru’s picture

socialnicheguru commented

I get this error once I apply the patch
then try to place the block

Error: Call to undefined method Drupal\\Core\\Entity\\EntityTypeManager::getFieldStorageDefinitions() in drupal-8.4.5/html/modules/download/fieldblock/src/Plugin/Block/FieldBlock.php on line 108

sutharsan’s picture

sutharsan commented
Status: Needs review » Needs work

Back to 'Needs work' as per remark in #3.

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs work » Needs review
StatusFileSize
new fieldblock_entity_manager_2864259_5.patch13.27 KB
new fieldblock_interdiff_2_5.txt3.59 KB

Created a new patch which fixes #3 issue.

sutharsan’s picture

sutharsan commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

Thanks for working on this. However the patch no longer applies.

+++ b/src/BlockEntityStorage.php
@@ -53,16 +53,16 @@ class BlockEntityStorage extends ConfigEntityStorage {
+   * @param \Drupal\Core\Entity\EntityTypeManagerInterface $entity_type_manager
    *   The entity manager.

The descriptions should be modified too.

FieldBlock::getEntity also has an $this->entityManager, I think this is missing in the patch.

sutharsan’s picture

sutharsan commented
Issue tags: -Needs reroll
StatusFileSize
new fieldblock_entity_manager_2864259_7.patch12.88 KB

Rerolled

sutharsan’s picture

sutharsan commented
Status: Needs work » Needs review
StatusFileSize
new fieldblock_entity_manager_2864259_8.patch14.24 KB
new interdiff-2864259-7-8.txt7.58 KB

Changes:

  • Changed descriptions as commented in #6
  • Added missing entityTypeManger in FieldBlock
  • Changed entity_*_manger variables to lowerCamelCase.

  • Sutharsan committed 39a57c4 on 8.x-2.x 
    Issue #2864259 by Sutharsan, nkoporec, Pavan B S: Replace all usages of...
sutharsan’s picture

sutharsan commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.