see #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)
Lists of tests to convert

\Drupal\block_content\Tests\BlockContentCreationTest
\Drupal\block_content\Tests\BlockContentListTest
\Drupal\block_content\Tests\BlockContentListViewsTest
\Drupal\block_content\Tests\BlockContentTranslationUITest
\Drupal\block_content\Tests\BlockContentValidationTest

Views tests:
BlockContentFieldFilterTest.php
BlockContentIntegrationTest.php
BlockContentRedirectTest.php
BlockContentTestBase.php
FieldTypeTest.php
RevisionRelationshipsTest.php

Out of Scope:
\Drupal\block_content\Tests\BlockContentTypeTest #2887311: Convert BlockContentTypeTest web tests to browser tests for block_content module

CommentFileSizeAuthor
#15 interdiff-2864005-13-15.txt6.92 KBnaveenvalecha
#15 2864005-15.patch13.28 KBnaveenvalecha
#13 interdiff-2864005-11-13.txt714 bytesnaveenvalecha
#13 2864005-13.patch6.36 KBnaveenvalecha
#11 2864005-11.patch7.06 KBnaveenvalecha
#7 interdiff-4-7.txt809 bytesjofitz
#7 2864005-7.patch7.02 KBjofitz
#4 interdiff-2864005-2-4.txt729 bytesgoz
#4 convert_web_tests_to-2864005-4.patch8.18 KBgoz
#2 convert_web_tests_to-2864005-2.patch9.07 KBgoz

Comments

GoZ created an issue. See original summary.

goz’s picture

goz commented
Status: Active » Needs review
StatusFileSize
new convert_web_tests_to-2864005-2.patch9.07 KB

I don't convert BlockContentTestBase which needs first #2830773: Add legacy for clickLinkPartialName() method for browser tests to be fixed.

Status: Needs review » Needs work

The last submitted patch, 2: convert_web_tests_to-2864005-2.patch, failed testing.

goz’s picture

goz commented
Status: Needs work » Needs review
StatusFileSize
new convert_web_tests_to-2864005-4.patch8.18 KB
new interdiff-2864005-2-4.txt729 bytes

Remove BlockContentUpdateTest.php from BTB conversion patch and put it back as WTB test since extends WTB methods.

dawehner’s picture

dawehner
Primary language German
commented

What is up with \Drupal\block_content\Tests\BlockContentTypeTest ?

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work
jofitz’s picture

jofitz
he/him
commented
Status: Needs work » Needs review
StatusFileSize
new 2864005-7.patch7.02 KB
new interdiff-4-7.txt809 bytes
  1. Moved \Drupal\block_content\Tests\BlockContentTypeTest.
  2. Removed (self-referencing) @deprecated from \Drupal\Tests\block_content\Functional\BlockContentTestBase.

Status: Needs review » Needs work

The last submitted patch, 7: 2864005-7.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
commented 
1) Drupal\Tests\block_content\Functional\BlockContentTypeTest::testBlockContentTypeEditing
Behat\Mink\Exception\ExpectationException: The string "Body" appears in the HTML response of this page, but it should not.

I guess this actually fetches the <body> tag?

michielnugter’s picture

michielnugter commented
Issue tags: +phpunit initiative
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review
StatusFileSize
new 2864005-11.patch7.06 KB

Accommodated #9

This patch will fail with two errors

1) Drupal\Tests\block_content\Functional\BlockContentTypeTest::testBlockContentTypeEditing
Object of class Behat\Mink\Element\NodeElement could not be converted to string

/var/www/html/core/modules/system/src/Tests/Menu/AssertBreadcrumbTrait.php:102
/var/www/html/core/modules/system/src/Tests/Menu/AssertBreadcrumbTrait.php:61
/var/www/html/core/modules/system/src/Tests/Menu/AssertBreadcrumbTrait.php:39
/var/www/html/core/modules/block_content/tests/src/Functional/BlockContentTypeTest.php:126

The BlockContentTypeTest:: testBlockContentTypeEditing is using assertBreadcrumb which is part of the AssertBreadcrumbTrait This trait is also being used by the couple of Webtests. So Should we add another copy of AssertBreadcrumbTrait for BTB tests and change its functions accordingly?

2) Drupal\Tests\block_content\Functional\BlockContentTypeTest::testsBlockContentAddTypes
PHPUnit_Framework_Exception: Fatal error: Call to undefined method Drupal\Tests\block_content\Functional\BlockContentTypeTest::clickLinkPartialName() in /var/www/html/core/modules/block_content/tests/src/Functional/BlockContentTypeTest.php on line 207

Caused by
exception 'ErrorException' with message 'unserialize(): Error at offset 0 of 224 bytes' in /var/www/html/vendor/phpunit/phpunit/src/Util/PHP.php:114
Stack trace:
#0 [internal function]: PHPUnit_Util_PHP->{closure}(8, 'unserialize(): ...', '/var/www/html/v...', 114, Array)
#1 /var/www/html/vendor/phpunit/phpunit/src/Util/PHP.php(114): unserialize('\nFatal error: C...')
#2 /var/www/html/vendor/phpunit/phpunit/src/Util/PHP.php(52): PHPUnit_Util_PHP->processChildResult(Object(Drupal\Tests\block_content\Functional\BlockContentTypeTest), Object(PHPUnit_Framework_TestResult), '\nFatal error: C...', '')
#3 /var/www/html/vendor/phpunit/phpunit/src/Framework/TestCase.php(722): PHPUnit_Util_PHP->runTestJob('

This class requires clickLinkPartialName function. In which class we're adding the new helper functions?

//Naveen

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: Convert web tests to browser tests for block_content module » [PP-1] Convert web tests to browser tests for block_content module
Status: Needs review » Postponed

Postponed on #2887099: Menu: convert system functional tests to PHPUnit

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Title: [PP-1] Convert web tests to browser tests for block_content module » Convert web tests to browser tests for block_content module
Assigned: goz » Unassigned
Issue summary: View changes
Status: Postponed » Needs review
StatusFileSize
new 2864005-13.patch6.36 KB
new interdiff-2864005-11-13.txt714 bytes

I have moved the \Drupal\block_content\Tests\BlockContentTypeTest to out of scope and added a followup issue to convert it #2887311: Convert BlockContentTypeTest web tests to browser tests for block_content module and postponed the follow-up issue on the other issue so that we could proceed here with minimal disruption.

@Goz,
Thanks for the work that helped to keep this issue forward. I'm unassigning it as this issue is ready for review.

//Naveen

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue summary: View changes
Status: Needs review » Needs work

Looking good so far, the list to convert didn't have the Views tests in it yet, but we need to do these too.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new 2864005-15.patch13.28 KB
new interdiff-2864005-13-15.txt6.92 KB

Here we go with Views tests as well.

//Naveen

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Patch looks good.

- Everything in scope is moved
- Deprecated base classes
- No tests in core that use the deprecated base classes except those we have a follow up for here.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Updating issue credit

  • larowlan committed 27ab301 on 8.4.x 
    Issue #2864005 by naveenvalecha, GoZ, Jo Fitzgerald, Lendude: Convert...

  • larowlan committed 2a97f85 on 8.3.x 
    Issue #2864005 by naveenvalecha, GoZ, Jo Fitzgerald, Lendude: Convert...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Ran the tests locally, no deprecations.

Committed as 27ab301 and pushed to 8.4.x.

As applies cleanly and passes on 8.3, cherry-picked as 2a97f85 and pushed to 8.3.x.

Great progress being made here - thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.