The current promotion edit form is a nightmare of disorganization and impossibility to manage. Let's fix this by doing something close to what we have in 1.x via discount module.

Proposed

1.x

CommentFileSizeAuthor
#4 screencapture-commerce2x-platform-32775-promotion-2-edit-1490651021909.png146.59 KBmglaman
#3 make_the_promotion_form-2863495-3.patch6.51 KBmglaman
#2 Add_promotion___Site-Install.png79.91 KBmglaman
#2 Edit_Testing_Coupons___Site-Install.png63.05 KBmglaman
Add_order_discount_commerce_discount___Site-Install.png76.01 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new Edit_Testing_Coupons___Site-Install.png63.05 KB
new Add_promotion___Site-Install.png79.91 KB

Okay, here are two WIP forms whichmake it a LOT better.

and

The only issue is losing the preview of settings when editing. However I feel a lot of this could be conveyed on promotion listing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: Unassigned » mglaman
Status: Active » Needs work
StatusFileSize
new make_the_promotion_form-2863495-3.patch6.51 KB

WIP patch.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new screencapture-commerce2x-platform-32775-promotion-2-edit-1490651021909.png146.59 KB

Attaching proposed.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

The PR is up at https://github.com/drupalcommerce/commerce/pull/692. Once passes we'll merge it up.

  • mglaman committed 4351967 on 8.x-2.x 
    Issue #2863495 by mglaman: Make the promotion form more friendly
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

Woo!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.