Problem/Motivation

Into Fieldset, see exceed space on top because padding is wrong.

space top

Proposed resolution

Unify padding.

Or 30px 18px --> example:

30-18

Or Better, i like this 18px for all --> example:

now

CommentFileSizeAuthor
#15 visually_hidden_-2863439-15.patch437 bytesbandanasharma
#4 now.png20.58 KBnesta_
#4 30px-18px.png21.51 KBnesta_
#2 visually_hidden_-2863439-2.patch429 bytesnesta_
#2 correct-hidden.png45.65 KBnesta_
#2 Space-padding.png37.72 KBnesta_
#2 date-space-before.png19.1 KBnesta_

Issue fork seven-2863439

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yoroy created an issue. See original summary.

nesta_’s picture

nesta_ commented
Status: Active » Needs review
Issue tags: +DevDaysSeville
StatusFileSize
new date-space-before.png19.1 KB
new Space-padding.png37.72 KB
new correct-hidden.png45.65 KB
new visually_hidden_-2863439-2.patch429 bytes

How can reproduce this example? I have this, but the class hidden is not a cause to space top.
before

Space top is cause by padding top irregular: 30px 18px 18px

space

correct

now:

Only local images are allowed.

yoroy’s picture

yoroy commented

The I was wrong about what causes the extra spacing! The best next step would be to come up with a better issue title and description :)

nesta_’s picture

nesta_ commented
Title: "visually-hidden" creates unwanted whitespace on fieldsets » Wrong padding into Fieldset generate unnecessary space top
Issue summary: View changes
StatusFileSize
new 30px-18px.png21.51 KB
new now.png20.58 KB
nesta_’s picture

nesta_ commented

Thank you yoroy. a Hug!

nesta_’s picture

nesta_ commented

any can review with last path?

idebr’s picture

idebr commented
Component: markup » CSS
nesta_’s picture

nesta_ commented
Component: CSS » Seven theme
Issue tags: +CSS

Change component CSS to Seven Theme. and add tag CSS :)

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

bandanasharma’s picture

bandanasharma commented
StatusFileSize
new visually_hidden_-2863439-15.patch437 bytes

Re-roll the #2 patch for the 9.1.x

tanubansal’s picture

tanubansal commented

Patch #15 working fine on 9.1

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented

I kinda like it how it is. Especially if a label is involved. Using 18px with a label looks crunched. Also seven to my knowledge is going to be replaced by claro eventually.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Project: Drupal core » Seven
Version: 9.5.x-dev » 1.0.0-alpha1
Component: Seven theme » Code

The Seven theme has been removed from Drupal 10 core. I confirmed that this issue only affects Seven and no other themes included with Drupal core, so I am moving this to the contributed Seven project.

chetansonawane’s picture

chetansonawane
he/him
Location Gujarat, India 🇮🇳
commented
Assigned: Unassigned » chetansonawane
chetansonawane’s picture

chetansonawane
he/him
Location Gujarat, India 🇮🇳
commented

Yes smustgrave, If legend tag will present then this looks like crunched. I applied this #15 patch, padding set as 18px but in my case lelgend tag is also there. so it will not work. making this issue to Needs work

chetansonawane’s picture

chetansonawane
he/him
Location Gujarat, India 🇮🇳
commented
Status: Needs review » Needs work
chetansonawane’s picture

chetansonawane
he/him
Location Gujarat, India 🇮🇳
commented
Assigned: chetansonawane » Unassigned
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Wrong padding into Fieldset generate unnecessary space top » Wrong padding into fieldsets generates unnecessary space on top
Version: 1.0.0-alpha1 » 1.0.x-dev
Issue summary: View changes
Issue tags: +Needs merge request

avpaderno opened merge request !75

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Needs review
Issue tags: -Needs merge request
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: avpaderno » Unassigned
Status: Needs review » Closed (outdated)
Related issues: +#3028704: Legend text overflow issue on small viewports due to absolute positioning

This has been already fixed in #3028704: Legend text overflow issue on small viewports due to absolute positioning.

avpaderno closed merge request !75