Upgrade from Workbench Moderation to Content Moderation

Agreed. We have plans to cut a new experimental branch prior to the 2.1.0 (core 8.3.0) release on 5 April. The goal of that branch is to work to get stuff like this stable and ultimately ported back to the mainline 8.x-2.x branch. Will also need a migration path from WBM -> content moderation. Don't think we have an issue for that yet.

Postponed on: #2862124: Create new Lightning Experimental Branch and move experimental components there and a migration path from WBM to CM.

#2862124: Create new Lightning Experimental Branch and move experimental components there has landed, so...time to unfreeze this bad boy.

#2860097: Ensure that content translations can be moderated independently is a bug that might also need to be taken into account. I don't know if there is an equivalent issue for workbench_moderation, but if workbench_moderation already has a workaround, we might not want to upgrade and regress that.

Good point re forward revisions and translations. Currently, Lightning recommends using the Content Translation Moderation module (see: http://lightning.acquia.com/blog/forward-revisions-and-translated-content) but we're aware that the workaround there is still buggy - especially for complex workflows.

So right now, WBM (and Lightning Workflow) allow you to create a situation where you do have multiple forward revisions. And publishing one of those results in unexpected behavior. So I'm inclined to say that the workaround CM currently has in place (that is, disallowing that situation from arising) is better than the current situation.

We have at least one large organization currently using Lightning Workflow with an extremely complex (but totally reasonable) workflow. I'll reach out to them and see what the ramifications would be of us _not_ blocking on this.

Now that I think about this a little more, we _do_ offer a workaround for WBM, even if it is buggy and unsupported. Migrating to CM would mean pulling the rug out from under people who are using that workaround. So I think I've changed my mind here... and I _am_ inclined to block on a solution (patch or otherwise) for forward revisions and translated content. Will update the IS once we get a consensus.

If we're blocking on Views and Forward Translations, it probably makes sense to block on #2815221: Add ability to use Quick Edit to the latest_revision route as well.

Here's a reroll of #2815221-69: Add ability to use Quick Edit to the latest_revision route for 8.4.x -- we'll need it.

Hi amazing Lightning team!

Is there anything I can do to help move this issue along? We are 2-3 weeks away from launching our new Drupal 8 site based on lightning for open.canada.ca.

Unfortunately we have a huge blocker due to workbench moderation, which surprisingly I can't replicate in content moderation. Essentially the bug makes the site unusable for users other then administrators in postgresql. https://www.drupal.org/project/drupal/issues/2920527

We are already on the Lightning 2.2.3 release with Drupal 8.4.2. Right now I am trying to decide if best to wait till this gets it in or try to backport some logic from content moderation to workbench moderation. Though I don't relish updating about 8000 nodes etc from workbench to content moderation :P

Thanks for any information you can provide :)

Hi. Our current target is 6 December for this. So that might be cutting it close for you. But this update path will be FAR better then trying roll your own or backport stuff.

We might have a branch as early as tomorrow that you could use for testing which would help (we could even throw an alpha tag on it if that helps). But no guarantees.

FWIW, it's going well, and I expect to hit the 6 Dec date. It'd be great if you could help test though, so I'll try to ping you when we have a branch up.

Thank you for the response and that is awesome news about the progress!

Count me in to help with any testing.

I wasn't making progress on determining why content moderation doesn't have the issue so happy this is even an option.

My situation is easier as I have everything automated through migrate + migration subscribers etc so the upgrade from content that existed in workbench and then being converted to content moderation isn't an issue. Though I'd happily test the update path for you too.

Thanks again!

Got my two repos successfully testing off of your dev-content-moderation-migration branch and followed the same adjustments that was made in your profile:

https://github.com/open-data/od/pull/197
https://github.com/drupalwxt/wxt/pull/95

Will be giving it some review tomorrow :)

Current known regressions:

1. /admin/content view does not show current moderation state.
2. /admin/content view does not show if a node has unpublished edits.
3. /admin/content view does not allow filtering by moderation state.
4. Lightning Scheduled Updates does not allow for scheduling multiple nodes at once.

Of those, #2 and #3 are our highest priority. This is based on the 2.2.4-alpha2 tag. You can test against that tag, or HEAD of the content-moderation-migration branch.

Just chiming in after testing, that my postgresql bug is indeed gone with content moderation, so that was a huge release blocker at least for me now gone. Based on your list only #1-#3 are important for me, as for right now we disable lightning_scheduled_updates and as mentioned the upgrade from workbench => content moderation isn't needed as I'll just be migrating on top of content moderation.

Just wanted to say thanks for all of your work on this. The update path was pretty easy and just from following your P.R. could easily determine the changes that needed to be made. Though I noticed that status went from hidden: true to displayed. I assume content moderation is overriding that area now.

It looks like the views patches are mostly ready to go?

I've opened several child issues and will open up a single meta followup for remaining tasks before we tag 2.2.4. But I think this initial migration task is ready for review.

2.2.4-alpha4 is tagged and ready for testing.

Followup meta issue: #2927364: [META] Improve Content Moderation integrations