Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
The d6 and d7 source plugin, LanguageContentSettings do not have tests. Let's create them.
Comment | File | Size | Author |
---|---|---|---|
#15 | interdiff-2862791-4-15.txt | 785 bytes | mitrpaka |
#15 | 2862791-15.patch | 4.32 KB | mitrpaka |
#13 | 2862791-13.patch | 4.38 KB | rajeevk |
#4 | 2862791-4.patch | 4.37 KB | jofitz |
Comments
Comment #2
harings_rob CreditAttribution: harings_rob at Harings.be for Nuvole commentedI think it actually does have coverage:
https://api.drupal.org/api/drupal/core%21modules%21language%21tests%21sr...
https://api.drupal.org/api/drupal/core%21modules%21language%21tests%21sr...
Comment #3
quietone CreditAttribution: quietone as a volunteer commented@harings_rob, thanks for looking into this. The test you refer to is the migration test, which will run the necessary migrations and confirm that the destination db has the correct values. The test that is missing is a test of the source plugin alone. The test will reside in ./core/modules/language/tests/src/Kernel/Plugin/migrate/source/d6 and extend MigrateSqlSourceTestBase. Since this source plugin is only getting data from node_type table, it will be similar to the test of the NodeType plugin, ./icore/modules/node/tests/src/Kernel/Plugin/migrate/source/d6/NodeTypeTest.php
Comment #4
jofitz CreditAttribution: jofitz at ComputerMinds commentedAdded LanguageContentSettings source plugin tests for both D6 and D7.
Comment #5
quietone CreditAttribution: quietone as a volunteer commented@Jo Fitzgerald, thank you. I was thinking we should add a test to cover both cases of i18n_lock_mode in the D7 version. And while thinking about that realized that this needs to be postponed on #2862006: MigrateSourceTestBase returns false positives for most plugin tests.
Comment #6
heddnComment #7
heddnComment #8
jofitz CreditAttribution: jofitz at ComputerMinds commentedNo longer blocked.
Comment #9
quietone CreditAttribution: quietone as a volunteer commentedAssign to myself to review.
Comment #10
quietone CreditAttribution: quietone as a volunteer commentedd6/LanguageContentSettingsTest.php is failing locally. So retesting this.
Comment #12
quietone CreditAttribution: quietone as a volunteer commentedUnassigning, so I can review.
Comment #13
rajeevkRe-rolling patch for test queue
Comment #15
mitrpaka CreditAttribution: mitrpaka as a volunteer commentedLanguageContentSettings source plugin test updated for D6.
Comment #16
kekkisI see green!
Comment #19
catchCommitted/pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!