The d6 and d7 source plugin, LanguageContentSettings do not have tests. Let's create them.

CommentFileSizeAuthor
#15 interdiff-2862791-4-15.txt785 bytesmitrpaka
#15 2862791-15.patch4.32 KBmitrpaka
#13 2862791-13.patch4.38 KBrajeevk
#4 2862791-4.patch4.37 KBjofitz

Comments

quietone created an issue. See original summary.

harings_rob’s picture

harings_rob commented
Issue tags: +DevDaysSeville

I think it actually does have coverage:

https://api.drupal.org/api/drupal/core%21modules%21language%21tests%21sr...
https://api.drupal.org/api/drupal/core%21modules%21language%21tests%21sr...

quietone’s picture

quietone commented

@harings_rob, thanks for looking into this. The test you refer to is the migration test, which will run the necessary migrations and confirm that the destination db has the correct values. The test that is missing is a test of the source plugin alone. The test will reside in ./core/modules/language/tests/src/Kernel/Plugin/migrate/source/d6 and extend MigrateSqlSourceTestBase. Since this source plugin is only getting data from node_type table, it will be similar to the test of the NodeType plugin, ./icore/modules/node/tests/src/Kernel/Plugin/migrate/source/d6/NodeTypeTest.php

jofitz’s picture

jofitz
he/him
commented
Status: Active » Needs review
StatusFileSize
new 2862791-4.patch4.37 KB

Added LanguageContentSettings source plugin tests for both D6 and D7.

quietone’s picture

quietone commented
Status: Needs review » Postponed

@Jo Fitzgerald, thank you. I was thinking we should add a test to cover both cases of i18n_lock_mode in the D7 version. And while thinking about that realized that this needs to be postponed on #2862006: MigrateSourceTestBase returns false positives for most plugin tests.

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Related issues: +#2862006: MigrateSourceTestBase returns false positives for most plugin tests
heddn’s picture

heddn
Primary language English
Location Illinois
commented
jofitz’s picture

jofitz
he/him
commented
Status: Postponed » Needs review

No longer blocked.

quietone’s picture

quietone commented
Assigned: Unassigned » quietone

Assign to myself to review.

quietone’s picture

quietone commented

d6/LanguageContentSettingsTest.php is failing locally. So retesting this.

Status: Needs review » Needs work

The last submitted patch, 4: 2862791-4.patch, failed testing.

quietone’s picture

quietone commented
Assigned: quietone » Unassigned

Unassigning, so I can review.

rajeevk’s picture

rajeevk
Location London
commented
Status: Needs work » Needs review
Issue tags: -DevDaysSeville
StatusFileSize
new 2862791-13.patch4.38 KB

Re-rolling patch for test queue

Status: Needs review » Needs work

The last submitted patch, 13: 2862791-13.patch, failed testing.

mitrpaka’s picture

mitrpaka commented
Status: Needs work » Needs review
StatusFileSize
new 2862791-15.patch4.32 KB
new interdiff-2862791-4-15.txt785 bytes

LanguageContentSettings source plugin test updated for D6.

kekkis’s picture

kekkis
he/him
Primary language Finnish
Location Pirkkala
commented
Status: Needs review » Reviewed & tested by the community

I see green!

  • catch committed ef519ee on 8.4.x 
    Issue #2862791 by mitrpaka, Jo Fitzgerald, RajeevK, quietone,...

  • catch committed 58a0046 on 8.3.x 
    Issue #2862791 by mitrpaka, Jo Fitzgerald, RajeevK, quietone,...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.