Details & Accordion

According to caniuse.com, there are some regression problems with <details> elements and their support in Internet Explorer.

http://caniuse.com/#feat=details

Some sort of html5 support should be added to core to handle these issues.

https://github.com/aFarkas/html5shiv

CommentFileSizeAuthor
14.details-and-accordion.png47.66 KBaaronchristian
#4 modernizer-3.3.1.jpg334.94 KBaaronchristian
#4 details-summary-IE-firefox.jpg1.59 MBaaronchristian

Comments

AaronChristian created an issue. See original summary.

aaronchristian’s picture

aaronchristian commented
aaronchristian’s picture

aaronchristian commented

So looking into a few more options to resolve the dependency issues.

  1. Element.details
  2. Details-Polyfill

This one seems to be the best option for us as it supports IE9+.

https://mathiasbynens.be/demo/html5-details-jquery

I think it would be a loss for Drupal 8 if we had to downgrade the HTML5 structure in core just to accommodate some regression as the trade-off isn't worth the effort.

aaronchristian’s picture

aaronchristian commented
StatusFileSize
new details-summary-IE-firefox.jpg1.59 MB
new modernizer-3.3.1.jpg334.94 KB

Been testing with IE9/10/11 & Firefox, it looks like the native support has already been covered through modernizr v3.3.1.

See attached images showing the working versions, as well as the code that's been added through core/misc/collapse.js

Details & Summary - IE9+/Firefox

Modernizr-v3.3.1

aaronchristian’s picture

aaronchristian commented
Status: Active » Needs review
aaronchristian’s picture

aaronchristian commented
Status: Needs review » Closed (works as designed)