Rename offcanvas to two words in code and comments.

@MaxFire thanks for working on this. You may not have introduced the standards violations. They have existed before.

When do the git diff are you using "-M" option? This will detect that files are renamed from for example "offcanvas.js" to "off-canvas.js" instead of thinking it is new file(hopefully). This will make patch smaller and will include lines.

I do something like
git diff -M 8.4.x > ../filename.patch

@Maxfire awesome work a couple more changes that need to make the test pass.

1. +++ b/core/modules/outside_in/outside_in.services.yml
   --- a/core/modules/outside_in/src/Ajax/OpenOffCanvasDialogCommand.php
   +++ b/core/modules/outside_in/src/Ajax/OpenOffCanvasDialogCommand.php
   
   +++ b/core/modules/outside_in/src/Ajax/OpenOffCanvasDialogCommand.php
   @@ -33,7 +33,7 @@ class OpenOffCanvasDialogCommand extends OpenDialogCommand {
   +    parent::__construct('#drupal-off_canvas', $title, $content, $dialog_options, $settings);
   
   +++ b/core/modules/outside_in/src/Tests/Ajax/OffCanvasDialogTest.php
   @@ -32,9 +32,9 @@ public function testDialog() {
   +      'selector' => '#drupal-off_canvas',
   
   +++ b/core/modules/outside_in/tests/src/FunctionalJavascript/OffCanvasTest.php
   @@ -12,23 +12,23 @@ class OffCanvasTest extends OutsideInJavascriptTestBase {
   +      $web_assert->elementNotExists('css', '#drupal-off_canvas');
   

   This is the html id attribute and should be #drupal-off-canvas.

   It is causing a test to fail.

2. +++ b/core/modules/outside_in/templates/outside-in-page-wrapper.html.twig
   index 761693b..f4b815d 100644
   --- a/core/modules/outside_in/tests/modules/offcanvas_test/offcanvas_test.routing.yml
   
   --- a/core/modules/outside_in/tests/modules/offcanvas_test/offcanvas_test.routing.yml
   +++ b/core/modules/outside_in/tests/modules/offcanvas_test/offcanvas_test.routing.yml
   

   The test module directory and file names should be update to match namespace, off_canvas_test.
   info, routing, etc files

   This cause the test not to find off_canvas_test module

@Maxfire awesome work!!! Tests pass and I just checked and there are no occurrences of "offcanvas" or "Offcanvas" in the files and no files name "offcanvas" lower case.

Looking at it further....

@Maxfire thanks for the updates
Uploading an interdiff between 27 and 31

Found some other variations in the comments still

1. Off-Canvas tray
2. off-canvas tray
3. off-canvas tray
4. off_canvas tray
5. off canvas tray
6. dialog-off-canvas tray
7. OffCanvas(no "tray")

These should all also be changed to "off-canvas dialog"
Just to be clear only the comments now are an issue. I think code and file names are perfect.

Sorry we were so inconsistent when creating this module :(

Also removing novice tag, tricky probably than we thought ;)

Almost there! Just a few more changes.

+++ b/core/modules/outside_in/tests/modules/offcanvas_test/src/Controller/TestController.php
@@ -96,12 +96,12 @@ public function linksDisplay() {
+   * Displays dialogs links to be displayed inside the off_canvas dialog.
...
+   * inside the off_canvas dialog.

+++ b/core/modules/outside_in/tests/src/FunctionalJavascript/OutsideInBlockFormTest.php
@@ -53,7 +53,7 @@ protected function setUp() {
+   * Tests opening off_canvas dialog by click blocks and elements in the blocks.

Change "off_canvas dialog" to "off-canvas dialog"

+++ b/core/modules/outside_in/tests/modules/offcanvas_test/src/Controller/TestController.php
@@ -96,12 +96,12 @@ public function linksDisplay() {
+   * @todo Update tests to check these links work in the off_canvas fialog.

Typo, "off_canvas fialog" should be "off-canvas dialog"

Just needs a re-roll.

Re-roll

@lauriii thanks for taking a look this issue.

re #42
1. fixed
2. Nice catch! That was problem with the search/replace probably for "offcanvas/off_canvas". Fixed

I also found 1 other case in outside_in.routing.yml where we were using off_canvas in a path where we didn't need to be. Fixed that too.

Another re-roll

Changing to new settings_tray.module component. @drpal thanks for script help! :)