Drupal 8.4.x adds image:image_url to available display plugins. This messes up the tests that assume/require an exact match for display plugins between a hard coded list and what Drupal reports is available.

CommentFileSizeAuthor
#4 2862333-tests-are-broken-4.patch945 bytesnickdickinsonwilde
#2 2862333-tests-are-broken-2.patch943 bytesnickdickinsonwilde

Comments

NickWilde created an issue. See original summary.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Assigned: nickdickinsonwilde » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2862333-tests-are-broken-2.patch943 bytes

This should fix that.
Somewhat refactors the test to just test that the tested displays are all available but allows Drupal to provide more without choking

Status: Needs review » Needs work

The last submitted patch, 2: 2862333-tests-are-broken-2.patch, failed testing.

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Needs work » Needs review
StatusFileSize
new 2862333-tests-are-broken-4.patch945 bytes

hmm I guess assertEmpty() isn't available through WebTestBase. Well that's easy to work around.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Issue tags: +D8Media

  • Dave Reid committed bdb4e9d on 8.x-1.x authored by NickWilde 
    Issue #2862333 by NickWilde: Fixed test failure with Drupal 8.4.x.
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #4 to 8.x-1.x. Thanks @NickWilde!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.