Making the code inline with Drupal coding standards.

CommentFileSizeAuthor
#6 drupalcs_error_remove-2861756-4.patch7.8 KBprajaankit
#3 error_in_composer_json-2861756-3.patch1.38 KBdishabhadra
#2 error_in_composer_json-2861756-2.patch4.78 KBdishabhadra

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Status: Active » Needs review
StatusFileSize
new error_in_composer_json-2861756-2.patch4.78 KB

Review my patch.

dishabhadra’s picture

dishabhadra commented
StatusFileSize
new error_in_composer_json-2861756-3.patch1.38 KB

Please ignore above one.

Added the new patch.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Title: Error in composer.json » Drupal Coding standards fixes
Issue summary: View changes
Status: Needs review » Needs work

@dishabhadra, not only the composer.json file; but other files also requires few coding standard fixes. Lets fix them here..

Reference from pareview : https://pareview.sh/node/1425

prajaankit’s picture

prajaankit commented
Assigned: dishabhadra » prajaankit
prajaankit’s picture

prajaankit commented
StatusFileSize
new drupalcs_error_remove-2861756-4.patch7.8 KB

Hi,

Fixed all the drupalcs errors, only two warnings are left please have look into that

[vagrant@localhost html]$ drupalcs first_time_login/

FILE: /var/www/html/first_time_login/first_time_login.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
107 | WARNING | Only string literals should be passed to t() where
| | possible
116 | WARNING | Only string literals should be passed to t() where
| | possible
----------------------------------------------------------------------

All other fixes is done, please review it.

prajaankit’s picture

prajaankit commented
Assigned: prajaankit » Unassigned
Status: Needs work » Needs review

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Status: Needs review » Fixed

Thanks dishabhadra and prajaankit..!!
Committed the patch to 8.x-1.x branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.