Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Making the code inline with Drupal coding standards.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | drupalcs_error_remove-2861756-4.patch | 7.8 KB | prajaankit |
| #3 | error_in_composer_json-2861756-3.patch | 1.38 KB | dishabhadra |
| #2 | error_in_composer_json-2861756-2.patch | 4.78 KB | dishabhadra |
Comments
Comment #2
dishabhadra commentedReview my patch.
Comment #3
dishabhadra commentedPlease ignore above one.
Added the new patch.
Comment #4
neerajsingh@dishabhadra, not only the composer.json file; but other files also requires few coding standard fixes. Lets fix them here..
Reference from pareview : https://pareview.sh/node/1425
Comment #5
prajaankit commentedComment #6
prajaankit commentedHi,
Fixed all the drupalcs errors, only two warnings are left please have look into that
[vagrant@localhost html]$ drupalcs first_time_login/
FILE: /var/www/html/first_time_login/first_time_login.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
107 | WARNING | Only string literals should be passed to t() where
| | possible
116 | WARNING | Only string literals should be passed to t() where
| | possible
----------------------------------------------------------------------
All other fixes is done, please review it.
Comment #7
prajaankit commentedComment #9
neerajsinghThanks dishabhadra and prajaankit..!!
Committed the patch to 8.x-1.x branch.