Problem/Motivation

#2880149: Convert taxonomy terms to be revisionable has made taxonomy terms revisionable, including the parent and weight fields.

However, that patch included an entity-level constraint and various UI/form restrictions that disallow updating the parent of a term in pending revisions.

Proposed resolution

Refactor the taxonomy storage handler so it's able to work with latest revisions as well, not just default ones.

Remaining tasks

Do it.

User interface changes

Updating the parent of a term will be possible in the UI.

API changes

TBD.

Data model changes

None.

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
hchonov’s picture

hchonov
Primary language Bulgarian
Location Burgas
commented

Should we make the Taxonomy hierarchy a revisionable entity or do you have something else in mind?

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

This would be fixed more or less automatically by #2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration no? I mean with that we could just set the parent field to be reivisionable and be done, unless I'm missing something.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Yeah, #2543726: Make $term->parent behave like any other entity reference field, to fix REST and Migrate support and de-customize its Views integration would solve it, but we'd still need the dance to keep the hierarchy in sync.

Just going to point out Entity reference hierarchy which is an ER field with a materialized nested-set representation of the hierarchy.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

amateescu’s picture

amateescu commented
Title: Taxonomy hierarchy should be revision-aware » Add support for changing taxonomy term parents in pending revisions
Issue summary: View changes

Changing title and scope based on #2880149-249: Convert taxonomy terms to be revisionable.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

johnwebdev’s picture

johnwebdev commented
Status: Postponed » Active

The mentioned issues are in. So I guess this should not be postponed anymore?

This is semi-related to the work I've been doing in: #2315773-182: Create a menu link field type/widget/formatter and https://www.drupal.org/project/menu_link/issues/3092566 (but really haven't come up with any solution yet).

The problem here is that the Terms overview UI represents the default / published state of the hierarchy. If you change the terms hierarchy over there, the default revision should be updated, but that would mean that the pending revisions are no longer in sync. This is currently prevented by the implemented form restrictions, which I am guessing the goal of this issue is to solve?

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.