Closed (fixed)
Project:
Cloudwords for Multilingual Drupal
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
16 Mar 2017 at 16:13 UTC
Updated:
21 Mar 2017 at 01:41 UTC
Jump to comment: Most recent, Most recent file


Comments
Comment #2
mgoncalves commentedComment #3
mgoncalves commentedBesides hook_enable to hook_install, was change language_list() to \Drupal::languageManager()->getLanguages().
Comment #4
mgoncalves commentedComment #5
rickyoh commentedCan you please resubmit a patch that only fixes the issue stated in this ticket?
Fixing occurrences of "language_list()" is not useful as the current functions and methods that implement them are no longer used and need to be either pulled out or significantly altered for D8 anyways.
Comment #6
mgoncalves commentedHello @rickyoh,
You cannot install the module without change the language_list().
When you are installing Cloudwords for Multilingual Drupal, the first error will be "Fatal error: Call to undefined function language_list()".
Do you want the only occurrences listed even so ?
Thank you
Comment #7
rickyoh commented@mgoncalves
Yes, please leave those occurrences and I'll remove them shortly with a commit.
Can you rework your patch so it only addresses this issue at hand and make sure it can apply cleanly against the latest version of 8.x-1.x-dev?
Thanks!
Comment #8
mgoncalves commentedComment #9
mgoncalves commentedJust changed the hook install.
Comment #10
mgoncalves commentedComment #12
rickyoh commentedComment #13
rickyoh commented