In Core Update 8.2.7 (Security Update SA-CORE-2017-001)

It seems the class 'search-block-form' has been removed from the main search block in core theme 'classy'.
Whilst not a bug as such, this does mean themes either based on or sub themes of classy that use this class as an obvious theming/CSS hook for styling their main search box, will find this styling breaks after an update to 8.2.7.

Is there a security reason to remove this class?

CommentFileSizeAuthor
#4 useful_class_removed-2861127-3.patch752 byteslauriii

Comments

themeninja created an issue. See original summary.

TheThemerist’s picture

TheThemerist commented
Version: 8.2.x-dev » 8.2.7
berdir’s picture

berdir
Primary language German
Location Switzerland
commented

> Is there a security reason to remove this class?

No.

That's just me being blind/stupid, can safely be removed.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Active » Needs review
StatusFileSize
new useful_class_removed-2861127-3.patch752 bytes

This brings the class back

TheThemerist’s picture

TheThemerist commented

Thanks guys!

We only have a handful of live Drupal 8 sites here, so it wasn't too much trouble just to find-replace the class name we'd used for something more robust.
But i imagined for some who have shipped out quite a few D8 sites it may cause a bigger problem.

Thanks for the Patch lauriii

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

This looks fine to me but I guess it will only be added to 8.3 as there will be no further 8.2.x releases.

  • xjm committed ac6cb0e on 8.4.x 
    Issue #2861127 by lauriii, themeninja, Berdir: Useful Class Removed From...

  • xjm committed cc7c160 on 8.3.x 
    Issue #2861127 by lauriii, themeninja, Berdir: Useful Class Removed From...
xjm’s picture

xjm
she/her
Primary language English
commented
Version: 8.2.7 » 8.3.x-dev
Issue tags: -theming, -search +rc target

Yep, we agreed to fix this in 8.3.x, since the next release after 8.2.7 is 8.3.0.

Committed to 8.4.x and cherry-picked to 8.3.x. Thanks @themeninja for reporting this!

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.