Closed (fixed)
Project:
Commerce Shipping
Version:
8.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Mar 2017 at 02:25 UTC
Updated:
25 Jan 2022 at 13:43 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
bojanz commentedGood idea! Thank you for working on this.
Comment #3
bradjones1Updated for the new version of Symfony in Drupal core.
Comment #4
nathaniel commented#3 fixes illegal choice error when I do not have a default shipping method and click recalculate shipping after entering an address.
Comment #5
swickham commentedTested and it works fine.
One small nit, the doc comment needs to be formatted correctly to avoid a phpcs error, from
to
Comment #6
maticb commentedI've tested the patch in #3, which is working fine :)
I've also added a new patch with a simple modification as mentioned by @swickham in #5.
Comment #7
andyg5000Comment #8
andyg5000Comment #9
andyg5000Jeeze, I really borked those metadata changes :)
Comment #10
bradjones1Still needs tests. :-/
Comment #11
smccabe commentedNow with tests!
Comment #12
Nils LoewenThis patch works great. The interdiff removes a pesky 'createScreenshot' in the test.
The less graceful and uninformative error 'An illegal choice...' that previously came up has been replaced by more helpful: 'There are no shipping rates available for this address.'
Comment #13
mglaman👍
Comment #14
rszrama commentedThanks everyone, committing!
Comment #17
3cwebdev commentedI'm using commerce_shipping 8.x-2.0-beta7 and have verified that this patch has been committed to it but for some reason it is not working.
In my tests I make a checkout order without any valid shipping methods. I do see the message in the shipping information pane that states:
"There are no shipping rates available for this address."
However, I am still allowed to complete my checkout without any further warnings and prevention.
I see in the patch that it looks like it should be preventing the checkout if no valid methods are found and display the following message:
"A valid shipping method must be selected in order to check out."
But this is not occuring. Any ideas why?
Comment #18
inwebsol commented@3CWebDev Did you find a solution to this in the end? I am facing this issue with version 8.x-2.1.
Comment #19
guy_schneerson commented@3CWebDev and @inwebsol
I came across an edge case that may be related to the issue you experienced|: https://www.drupal.org/project/commerce_shipping/issues/3260362