Title is not picked up when it is a string.

CommentFileSizeAuthor
#9 title_can_be_a_plain_text-2860382-9.patch928 bytesduozersk
#7 interdiff.txt992 bytesgg24
#7 title_can_be_a_plain_text-2860382-7.patch1.21 KBgg24
#3 2860382-3-title-plain-text.patch916 bytespiggito
#2 sharethis-title-can-be-a-plain-text-2860382-8.x-2.x-dev.patch2.21 KBeugenechechel
sharethis.png138.62 KBeugenechechel

Comments

EugeneChechel created an issue. See original summary.

eugenechechel’s picture

eugenechechel commented
StatusFileSize
new sharethis-title-can-be-a-plain-text-2860382-8.x-2.x-dev.patch2.21 KB

Here is a patch that fixes it.

piggito’s picture

piggito commented
StatusFileSize
new 2860382-3-title-plain-text.patch916 bytes

Updating the patch for current 8.x-2.x-dev code.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

Let's see what not will show

The last submitted patch, 2: sharethis-title-can-be-a-plain-text-2860382-8.x-2.x-dev.patch, failed testing.

gg24’s picture

gg24 commented
Assigned: Unassigned » gg24
Status: Needs review » Needs work
gg24’s picture

gg24 commented
Assigned: gg24 » Unassigned
Status: Needs work » Needs review
StatusFileSize
new title_can_be_a_plain_text-2860382-7.patch1.21 KB
new interdiff.txt992 bytes

Minor changes to the above patch. I have added interdiff.txt as well.
Please review.

Thanks!

manojbisht_drupal’s picture

manojbisht_drupal commented
Status: Needs review » Reviewed & tested by the community

Working fine now.

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
StatusFileSize
new title_can_be_a_plain_text-2860382-9.patch928 bytes

To apply the patch in 7 to 8.x-2.0-beta3 you need to apply the patch from #2769897: Use base:// instead of $base_url first.

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x-2.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.