Problem/Motivation

In 9764cd5 a nice feature was added: action buttons are disabled when no selection is made. However, using form alteration I'm adding an "Add new record" button inside the VBO buttons area. The reason is to keep the visual consistency with the standard VBo buttons. After 9764cd5 alsoo this custom added button is disabled/enabled even, based on its business logic, he should not be influenced by the rows selection. You can add a new record even no row is selected

Proposed resolution

Allow exceptions when toggling buttons. If button has the class vbo-avoid-toggle, then ignore that button.

CommentFileSizeAuthor
#2 2860320-2.patch651 bytesclaudiu.cristea
buttons.png124.09 KBclaudiu.cristea

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Active » Needs review
StatusFileSize
new 2860320-2.patch651 bytes

Patch.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Issue summary: View changes

Thanks, I think this is a reasonable option. Are you ok with with s/avoid/prevent/?

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

Sure. Will you change that on commit, or you need a new patch?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Commit just need to get in front of a computer and give people chance to decent

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

Pushed to -dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.