Promotion Conditions need to save their configuration data explicitly with a submitConfigurationForm() method. Currently the form only saves due to a bug in the pluginselect element which creates a plugin using values from the form, rather than using the values in the database.

CommentFileSizeAuthor
#3 commerce-adjust_promotion_test_to_include_condition_negate-2860264-3.patch1.39 KBmikelutz
#2 commerce-save_promotion_configuration_values-2860264-2.patch1.93 KBmikelutz

Comments

mikeNCM created an issue. See original summary.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
StatusFileSize
new commerce-save_promotion_configuration_values-2860264-2.patch1.93 KB

This patch should fix it properly save the values.

mikelutz’s picture

mikelutz
He/Him
Primary language English
Location Michigan, USA
commented
StatusFileSize
new commerce-adjust_promotion_test_to_include_condition_negate-2860264-3.patch1.39 KB

Also noticed that the current -dev actually isn't saving the negate checkbox anyway, but we aren't testing for it. Here's a patch that tests for it, which failes in the current-dev, but works with #2 above.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Closed (duplicate)

Let's fix it all at once in #2859423: PluginSelect element creates plugin using raw form values for configuration