Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.This is a patch to make the current instructions for D3.js clearer.
Currently, the Status report (/admin/reports/status) gives this warning if D3.js is not found:
Webprofiler module requires D3.js library to properly render data. See README.md file to learn how to download it.
The webprofiler README.md says:
- d3.js: Webprofiler module requires D3 library 3.x (not 4.x) to render data.
Download https://github.com/d3/d3 into /libraries/d3/d3.min.jsThe compiled library isn't directly available in that repo, and my first inference was you had to clone the whole project, or install an npm package, when in fact all you need to do is download the correct version from the CDN.
So I've rewritten it to say that.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | interdiff-2860138-1-4.txt | 3.22 KB | wturrell |
| #4 | 2860138-4.patch | 3.06 KB | wturrell |
| |||
Comments
Comment #2
wturrell CreditAttribution: wturrell as a volunteer commentedComment #3
lussolucaI think that the correct way to install D3 and Highlight.js is using Composer, so we can rephrase the messages in the status page in that way.
Comment #4
wturrell CreditAttribution: wturrell as a volunteer commentedOK try this - revised version with:
- modified requirements message for D3 and Highlight.js
- install split into composer/manual methods in README.md
- put the composer.json section descriptions before the code fragments, rather than after, for clarity
- rephrase mention of composer/installers, remind people to check they have an entry for it
- reminder to run 'composer update' at the end
Comment #6
lussolucaGreat!
Committed and pushed to 8.x-1.x
Thanks
Comment #8
shaisamuel CreditAttribution: shaisamuel commented--