Closed (fixed)
Project:
Office Hours
Version:
8.x-1.0-alpha1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Mar 2017 at 01:03 UTC
Updated:
30 Mar 2017 at 20:59 UTC
Jump to comment: Most recent
Comments
Comment #3
johnvCommitted with attribution.
Thanks ripz0r, nice feature, which was on the bucket list a long time.
Comment #4
micahw156I just updated one of our Drupal 8 sites to office_hours-8.x-1.0-alpha1 and ran the database updates. office_hours_update_8003() did not properly extend the schema of my office hours fields.
This site has four fields with office_hours type:
Update 8003 specifically looks for tables matching %office_hours% and adds a field field_office_hours_comment to any found. This would presumably find the node__field_office_hours and node_revision__field_office_hours tables for a field named office_hours but does not work in this case.
Those table names don't match the field names above, and the schema field names should be field_winter_hours_comment, etc, as well.
The corresponding D7 update from #2553935: Add a comment field to each time slot (D7) uses a different process to identify and update tables, and does not appear to have this problem.
I don't have time to work up a proper patch right now, but I think the replacement update could do something like this to find the tables and field names that need updating:
Comment #6
johnvThis should to the trick. I'll provide a new version.
Thanks for the fast response.