Problem/Motivation

Filtering by profile in the content management tab is untested.

Proposed resolution

Add tests.

Remaining tasks

Add tests.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#4 2859535-profile-filtering-4.patch10.16 KBpenyaskito
#4 interdiff.txt2.06 KBpenyaskito
#3 2859535-profile-filtering-3.patch5.8 KBpenyaskito
#3 interdiff.txt3.49 KBpenyaskito
#2 2859535-profile-filtering-2.patch3.32 KBpenyaskito
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

penyaskito created an issue. See original summary.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Active » Needs review
FileSize
2859535-profile-filtering-2.patch3.32 KB

Attached patch with test.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
interdiff.txt3.49 KB
2859535-profile-filtering-3.patch5.8 KB

Code standards.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
FileSize
interdiff.txt2.06 KB
2859535-profile-filtering-4.patch10.16 KB

More code standards.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Title: Filtering by profile in the content management tab is untested » Add tests for Filtering by profile in the content management bulk form
Status: Needs review » Reviewed & tested by the community

Bot agrees that this patch matches coding standards.

  • penyaskito committed c1dafb6 on 8.x-1.x 
    Issue #2859535 by penyaskito: Add tests for Filtering by profile in the...
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾Seville 💃, Andalusia 🇪🇸, UTC+2 🇪🇺
CreditAttribution: penyaskito at Lingotek commented
Status: Reviewed & tested by the community » Fixed

Committed c1dafb6 and pushed to 8.x-1.x. Thanks!

  • penyaskito committed c1dafb6 on 8.x-2.x 
    Issue #2859535 by penyaskito: Add tests for Filtering by profile in the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.