The tags existence checking in BrightcoveUtil.php has some issue,

  $existing_tags = \Drupal::entityQuery('taxonomy_term')
     ->condition('name', $tag)
     ->execute();

If there is a taxonomy term with the same name in another vocabulary , the tags field in brightcove video will reference to it instead of referencing to taxonomy term in "Brightcove video tags".

User cannot save in the UI when referencing to the tags in another vocabulary.

CommentFileSizeAuthor
#2 0001-Issue-2859461-by-fgm-specify-the-BC-vid-in-util-quer.patch3.59 KBfgm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pan Lee created an issue. See original summary.

fgm’s picture

fgm
Primary language French
Location Paris, France
CreditAttribution: fgm at OSInet commented
Version: 8.x-1.1 » 8.x-1.2
Status: Active » Needs review
FileSize
0001-Issue-2859461-by-fgm-specify-the-BC-vid-in-util-quer.patch3.59 KB

This should address the issue.

I also made the vid name a constant for maintenability.

  • 7aa2e17 committed on 8.x-1.x 
    Issue #2859461 by fgm: Check brightcove video tags existance in its own...
yce’s picture

yce CreditAttribution: yce at Pronovix for BrightCove commented
Status: Needs review » Fixed

Thanks! Patch commited, although I've moved the TAGS_VID constant to the BrightcoveVideo entity.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.