Hi,
I just need to know how can I set free bonus products quantity ?
for example I just want to give my customers 1 bonus product against another product!
this means if I have 10 paid product so I should have 10 bonus product in basket! but at this time its only add 1 bonus product to the cart!!!
I just try to use rules but its not working!
So how can I do it ?

Thanks a lot

CommentFileSizeAuthor
#5 commerce_discount-free_bonus_products_quantity-2859302-5.patch1.29 KBrossb89

Comments

sonixax created an issue. See original summary.

sonixax’s picture

sonixax commented

Any Idea afte about two weeks ?

imrubio22’s picture

imrubio22 commented

I would also like this to work. I can get this to work with Discount Extra using the Per-quantity product discount options but it's not ideal because even the discounted item needs to be already added to the cart.

I like the Add Free Bonus Products option because it adds the bonus product to the cart but it should add 2 bonus products if 2 trigger products are in the cart as the original poster describes.

thanks in advance!

arefen’s picture

arefen commented

https://www.drupal.org/sandbox/rfnbnkr/2842310
this module solve your problem

rossb89’s picture

rossb89 commented
StatusFileSize
new commerce_discount-free_bonus_products_quantity-2859302-5.patch1.29 KB

Encountered this issue this morning.

The issue is, '1' is the hardcoded quantity value.

Written a simple patch that will pull the quantity in from the corresponding line item on the order, and set that instead of the hardcoded 1 value.

rossb89’s picture

rossb89 commented
Status: Active » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Category: Support request » Feature request
Issue tags: +Needs tests

Thanks for the patch and digging in @rossb89, it would be great if others who are loooking for this also test the patch and a test to ensure it works would be great if it could be added. (hint copy from existing tests and add a larger quantity and assert if its there in the checkout)

rossb89’s picture

rossb89 commented
Status: Needs review » Needs work

I had a think about this today... will look to add tests at some point when I have some time, but just thought of an issue where you might not always want multiple bonus products to match the cart quantity..

I think what's required here is a new extra option which effectively does what I patched here, 'add free bonus products (match cart quantity)' .. as you might not always want to have e.g. buy 5 get 5 free.. some offers might want buy 5 get 1 free, and with this patch, that would stop that functionality from being possible.

With an extra option, it would give the flexibility to have both use cases.

OR - try add a flag to the existing 'free bonus products' option .. 'match cart quantity' or somesuch.

Neo13’s picture

Neo13 commented

The patch would only work if free product and product in the condition to receive the free product are the same. That is not always the case.

narwhalbyte’s picture

narwhalbyte commented

This patch works great, but now we can't do buy x get 1 free.
It seems that the discount options "Offer same amount of free products as bought" and "quantity offered" are ignored.
Is there any way around this?