Coming from #2822837: Replace @expectedException @expectedExceptionMessage with $this->setExpectedException.

Using that annotations is bad practice, so we should add a sniff to DrupalPractice that creates a warning.

Comments

klausi created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) commented

In addition there are:

  • @expectedExceptionMessageRegExp - drupal core has 3 cases
  • @expectedExceptionCode - drupal core hasn't cases, but contrib modules have it (eg. acquia_lift)
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Issue tags: +needs documentation updates

Documentation needs update too, when this lands: https://www.drupal.org/docs/8/phpunit

  • klausi committed 984c54a on 8.x-2.x 
    feat(ExpectedExceptionSniff): Add sniff to forbid usage of PHPUnit @...
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Active » Fixed

Pushed a new sniff.

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Assigning credits.

Anonymous’s picture

Anonymous (not verified) commented

Super news!! You saved our issue again!

Only one absolutely nit typo:
$warning = '%s tags should not be used, use $§this->setExpectedException() or $this->expectException() instead';
$§ → $

  • klausi committed 79e8249 on 8.x-2.x 
    style(ExpectedExceptionSniff): Fix typo in sniff message (#2859286)
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented

Thanks, fixed that typo.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.