For branch tests, we could optionally provide a coding standard result delta that says "X" more/fewer coding standards detected.

Comments

Mixologic created an issue. See original summary.

drumm’s picture

Assigned: Unassigned » drumm

And for file testing, the difference with the branch test.

  • drumm committed c4e2d1c on 7.x-3.x
    Issue #2859036: Provide coding standards delta checks
    
drumm’s picture

Status: Active » Fixed
Issue tags: +needs drupal.org deployment

An example of this is at https://drumm-drupal.dev.devdrupal.org/pift-ci-job/761152

For non-branch tests, it only looks at the files which were scanned, the ones with changes.

jonathan1055’s picture

Thanks for the example but that url is password protected. Sounds good, though.

[edit: I just read the pop-up hint, and it tells you the id and pw. I should have looked more closely]

  • drumm committed bf95273 on 7.x-3.x
    Issue #2859036: Fix “-N less”
    
drumm’s picture

Issue tags: -needs drupal.org deployment

This has been deployed.

jonathan1055’s picture

This is a nice addition, thanks. But, the grammar pedant in me would like to point out that it should "n fewer" not "n less". For non-countable amounts it is ok, for example "less sugar" or "less spare time", but for discrete countable items it should be "fewer". The issue summary has the correct usage. http://www.dictionary.com/e/fewer-vs-less/

Hope you can change this ;-)

Thanks again for all your improvements to d.o. testing.

Jonathan

  • drumm committed c8304d8 on 7.x-3.x
    Issue #2859036 by drumm, jonathan1055: Grammar
    
drumm’s picture

Thanks, deployed that fix.

jonathan1055’s picture

Thank you :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.