Bad download path and return to blueprints link [#2858828]

Comment	File	Size	Author
#16	2858828-16.oa_export.Bad-download-path-and-return-to-blueprints-link.patch	2.2 KB	mpotter
#11	2858828-11.oa_export.Bad-download-path-and-return-to-blueprints-link.patch	2.25 KB	mpotter
#10	2858828-10.oa_export.Bad-download-path-and-return-to-blueprints-link.patch	2.23 KB	mpotter
#2	2858828-oa_export-badlinks-1.patch	1.6 KB	Jorrit

Comment #1

8 March 2017 at 14:51

Jorrit created an issue. See original summary.

Log in or register to post comments

Comment #2

Jorrit CreditAttribution: Jorrit at nCode commented 8 March 2017 at 14:55

File	Size
2858828-oa_export-badlinks-1.patch	1.6 KB

See patch

Log in or register to post comments

Comment #3

Jorrit CreditAttribution: Jorrit at nCode commented 8 March 2017 at 15:00

Status:

Active

» Needs review

Log in or register to post comments

Comment #4

mpotter CreditAttribution: mpotter at Phase2 commented 9 March 2017 at 13:24

I need a procedure to reproduce this. The current code works fine here and on Pantheon. Do you have clean_urls enabled? Is your Atrium site within a subdirectory of your server and if so do you have the $base_url set in your settings.php?

Log in or register to post comments

Comment #5

Jorrit CreditAttribution: Jorrit at nCode commented 9 March 2017 at 16:02

Are you saying that the return button is working on your installation?

Log in or register to post comments

Comment #6

Argus CreditAttribution: Argus as a volunteer commented 10 March 2017 at 22:11

Status:

Needs review

» Postponed (maintainer needs more info)

Could you post steps to reproduce the issue on a clean installation?

Log in or register to post comments

Comment #7

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented 14 March 2017 at 08:18

Status:

Postponed (maintainer needs more info)

» Active

I have an OpenAtrium site on Pantheon that I created to demonstrate another bug. Demonstrating this bug requires admin permissions so I will be sending the password of the user 'adminuser' to you via the Drupal contact form.

Log in at http://dev-issue-2854597.pantheonsite.io/admin
Go to http://dev-issue-2854597.pantheonsite.io/admin/structure/taxonomy/space_...
Click the download link in the Test row and wait until the process is completed
Click either the 'return to blueprints' button or the 'click here to download the file' link and notice that the links lead to 404 pages

Extra note: downloading the 'Default' taxonomy term causes an error.

Log in or register to post comments

Comment #8

mpotter CreditAttribution: mpotter at Phase2 commented 14 March 2017 at 12:35

I probably won't be able to get to this before next week (not in time for 2.615 unfortunately) but wanted to confirm that I received the email.

Log in or register to post comments

Comment #9

Argus CreditAttribution: Argus as a volunteer commented 14 March 2017 at 21:57

Confirming. Created a separate issue for the download error on the Default taxonomy term: #2860636: Downloading the 'Default' Blueprint taxonomy term causes an error

Log in or register to post comments

Comment #10

mpotter CreditAttribution: mpotter at Phase2 commented 15 March 2017 at 13:01

Status:

Active

» Needs review

File	Size
2858828-10.oa_export.Bad-download-path-and-return-to-blueprints-link.patch	2.23 KB

Here is a patch that should fix the Return link.

Log in or register to post comments

Comment #11

mpotter CreditAttribution: mpotter at Phase2 commented 15 March 2017 at 13:09

File	Size
2858828-11.oa_export.Bad-download-path-and-return-to-blueprints-link.patch	2.25 KB

Actually, the patch from #2 was also missing an "absolute". Here is an update.

Log in or register to post comments

Comment #12

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented 15 March 2017 at 13:12

Why is 'absolute' necessary?

Log in or register to post comments

Comment #13

mpotter CreditAttribution: mpotter at Phase2 commented 15 March 2017 at 15:01

"absolute" adds the "http://..." to the URL which is needed by the browser for the full href value printed in the blueprint-download-page.tpl file.

Log in or register to post comments

Comment #14

mpotter CreditAttribution: mpotter at Phase2 commented 15 March 2017 at 15:07

If you can, verify that the latest patch works for you and RTBC this and I'll try to get it into the next Atrium release.

Log in or register to post comments

Comment #15

Jorrit CreditAttribution: Jorrit at nCode for DOM Digital Online Media GmbH commented 22 March 2017 at 13:18

Status:

Needs review

» Reviewed & tested by the community

The patch works.

I still don't understand why absolute is necessary when the link is printed in the website itself. With 'absolute' = TRUE the HTML becomes:

<a href="http://host/admin/structure/taxonomy/space_type" class="btn btn-primary">Return to blueprints</a>

Without it, the link becomes:

<a href="/admin/structure/taxonomy/space_type" class="btn btn-primary">Return to blueprints</a>

The latter works fine and all links generated by Drupal look like that, so I do not understand your preference for 'absolute' = TRUE.

Log in or register to post comments

Comment #16

mpotter CreditAttribution: mpotter at Phase2 commented 22 March 2017 at 16:38

File	Size
2858828-16.oa_export.Bad-download-path-and-return-to-blueprints-link.patch	2.2 KB

You are correct. I thought the "absolute" was needed when working in a different subdirectory on a site. But I just did a test of this and it works fine without. So here is an updated patch that I'll commit for the next release.

Edited: This is basically the same as #2 so I'll make sure you get the credit