After starting the download procedure for a Space blueprint a page with a return button and a link with the text 'click here to download the file' is presented. Both links do not work because the Drupal paths are not translated to absolute urls.

CommentFileSizeAuthor
#16 2858828-16.oa_export.Bad-download-path-and-return-to-blueprints-link.patch2.2 KBmpotter
#11 2858828-11.oa_export.Bad-download-path-and-return-to-blueprints-link.patch2.25 KBmpotter
#10 2858828-10.oa_export.Bad-download-path-and-return-to-blueprints-link.patch2.23 KBmpotter
#2 2858828-oa_export-badlinks-1.patch1.6 KBJorrit

Comments

Jorrit created an issue. See original summary.

Jorrit’s picture

Jorrit commented
StatusFileSize
new 2858828-oa_export-badlinks-1.patch1.6 KB

See patch

Jorrit’s picture

Jorrit commented
Status: Active » Needs review
mpotter’s picture

mpotter commented

I need a procedure to reproduce this. The current code works fine here and on Pantheon. Do you have clean_urls enabled? Is your Atrium site within a subdirectory of your server and if so do you have the $base_url set in your settings.php?

Jorrit’s picture

Jorrit commented

Are you saying that the return button is working on your installation?

Argus’s picture

Argus commented
Status: Needs review » Postponed (maintainer needs more info)

Could you post steps to reproduce the issue on a clean installation?

Jorrit’s picture

Jorrit commented
Status: Postponed (maintainer needs more info) » Active

I have an OpenAtrium site on Pantheon that I created to demonstrate another bug. Demonstrating this bug requires admin permissions so I will be sending the password of the user 'adminuser' to you via the Drupal contact form.

  1. Log in at http://dev-issue-2854597.pantheonsite.io/admin
  2. Go to http://dev-issue-2854597.pantheonsite.io/admin/structure/taxonomy/space_...
  3. Click the download link in the Test row and wait until the process is completed
  4. Click either the 'return to blueprints' button or the 'click here to download the file' link and notice that the links lead to 404 pages

Extra note: downloading the 'Default' taxonomy term causes an error.

mpotter’s picture

mpotter commented

I probably won't be able to get to this before next week (not in time for 2.615 unfortunately) but wanted to confirm that I received the email.

Argus’s picture

Argus commented

Confirming. Created a separate issue for the download error on the Default taxonomy term: #2860636: Downloading the 'Default' Blueprint taxonomy term causes an error

mpotter’s picture

mpotter commented
Status: Active » Needs review
StatusFileSize
new 2858828-10.oa_export.Bad-download-path-and-return-to-blueprints-link.patch2.23 KB

Here is a patch that should fix the Return link.

mpotter’s picture

mpotter commented
StatusFileSize
new 2858828-11.oa_export.Bad-download-path-and-return-to-blueprints-link.patch2.25 KB

Actually, the patch from #2 was also missing an "absolute". Here is an update.

Jorrit’s picture

Jorrit commented

Why is 'absolute' necessary?

mpotter’s picture

mpotter commented

"absolute" adds the "http://..." to the URL which is needed by the browser for the full href value printed in the blueprint-download-page.tpl file.

mpotter’s picture

mpotter commented

If you can, verify that the latest patch works for you and RTBC this and I'll try to get it into the next Atrium release.

Jorrit’s picture

Jorrit commented
Status: Needs review » Reviewed & tested by the community

The patch works.

I still don't understand why absolute is necessary when the link is printed in the website itself. With 'absolute' = TRUE the HTML becomes:

<a href="http://host/admin/structure/taxonomy/space_type" class="btn btn-primary">Return to blueprints</a>

Without it, the link becomes:

<a href="/admin/structure/taxonomy/space_type" class="btn btn-primary">Return to blueprints</a>

The latter works fine and all links generated by Drupal look like that, so I do not understand your preference for 'absolute' = TRUE.

mpotter’s picture

mpotter commented
StatusFileSize
new 2858828-16.oa_export.Bad-download-path-and-return-to-blueprints-link.patch2.2 KB

You are correct. I thought the "absolute" was needed when working in a different subdirectory on a site. But I just did a test of this and it works fine without. So here is an updated patch that I'll commit for the next release.

Edited: This is basically the same as #2 so I'll make sure you get the credit

mpotter’s picture

mpotter commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.