Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Attached patch fixes coding standard issues.
Comment | File | Size | Author |
---|---|---|---|
#10 | mailsystem_2858665_10.patch | 22.33 KB | manishsaharan |
#8 | mailsystem-2858665-8.patch | 21.28 KB | daiwik.addweb |
#3 | Screen Shot 2017-03-08 at 7.55.45 PM.png | 60.34 KB | riddhi.addweb |
#3 | Screen Shot 2017-03-08 at 7.55.34 PM.png | 79.83 KB | riddhi.addweb |
#2 | fix_coding_standards-2858665-2.patch | 813 bytes | Munavijayalakshmi |
Comments
Comment #2
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commentedComment #3
riddhi.addweb CreditAttribution: riddhi.addweb at AddWeb Solution Pvt. Ltd. commented@Munavijayalakshmi ,thanks for the patch it works well. I checked it over Simplytest.Me with the help of coder module and with patch it removes the coding standard errors.PFA
Comment #4
Munavijayalakshmi CreditAttribution: Munavijayalakshmi at Valuebound commentedComment #5
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedI can see plenty more CS violations than what is fixed in the provided patch:
Comment #6
MatroskeenSee: #2858676: Fix coding standards violations.
Comment #7
MatroskeenRemoved back to "Needs work" because of different Drupal versions.
Comment #8
daiwik.addweb CreditAttribution: daiwik.addweb at AddWeb Solution Pvt. Ltd. commented@Matroskeen, Please find my attached that works to resolve the coding standard issues. Thanks!..
Comment #9
Manuel Garcia CreditAttribution: Manuel Garcia as a volunteer and at Appnovation for Pfizer, Inc. commentedI think its better to keep these in one line, since they are URLs
Is this actually an array, or a string?
This should be corrected for indentation also.
indentation is off
This should be left as is.
indentation.
Indentation
This should be rephrased to be a one line description.
It adds no value. Rather describe what is returned.
trailing space.
Incorrect. Leave as is.
Comment #10
manishsaharan CreditAttribution: manishsaharan as a volunteer and commentedThis patch will solve this issue
Comment #11
BerdirDid some cleanup on this, fixing @return's, php7 syntax and so on. Committed.