Hi,

On sites that clearly separated front office from back office (using an admin theme), the banner is not needed on the second one.

So, it should be allowed to choose on which theme the banner will be displayed or add an option "do not display on admin theme"

CommentFileSizeAuthor
#9 eu_cookie_compliance-select-theme-where-the-banner-should-be-displayed-2858380-9.patch3.32 KBsvenryen
#3 select_theme_where_the-2858380-3.patch3.26 KBbrentschuddinck

Comments

O'Briat created an issue. See original summary.

brentschuddinck’s picture

brentschuddinck commented

I'm currently working on a patch for this feature.

brentschuddinck’s picture

brentschuddinck commented
Status: Active » Needs review
StatusFileSize
new select_theme_where_the-2858380-3.patch3.26 KB

Patch created for this new feature. Check the 'exclude cookie compliance from admin theme' box on the module settings page to hide the cookie compliance on routes where the admin theme is used.

Status: Needs review » Needs work

The last submitted patch, 3: select_theme_where_the-2858380-3.patch, failed testing.

jeroent’s picture

jeroent
Primary language Dutch
Location 🇧🇪
commented
Status: Needs work » Needs review

Tests fail but seem unrelated to the patch.

Status: Needs review » Needs work

The last submitted patch, 3: select_theme_where_the-2858380-3.patch, failed testing.

svenryen’s picture

svenryen commented

@O'Briat, would a port of this feature from 7.x be sufficient #2900084: Port 7.x feature: Exclude admin pages or do you need something more?

svenryen’s picture

svenryen commented
Status: Needs work » Needs review
svenryen’s picture

svenryen commented
StatusFileSize
new eu_cookie_compliance-select-theme-where-the-banner-should-be-displayed-2858380-9.patch3.32 KB

I placed the option in the new "Advanced" section of the settings and also renamed the label to match the similar function in the 7.x-branch. Here's the patch.

svenryen’s picture

svenryen commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.