CommentFileSizeAuthor
#3 field_tools-replace_all_deprecated_uses-2858353-3.patch5.86 KBbkhandruk
#2 field_tools-replace_all_deprecated_uses-2858353-2.patch5.4 KBbkhandruk

Comments

rocket.man created an issue. See original summary.

bkhandruk’s picture

bkhandruk commented
Assigned: bkhandruk » Unassigned
Status: Active » Needs review
StatusFileSize
new field_tools-replace_all_deprecated_uses-2858353-2.patch5.4 KB

Replaced deprecated uses in module.

bkhandruk’s picture

bkhandruk commented
StatusFileSize
new field_tools-replace_all_deprecated_uses-2858353-3.patch5.86 KB

Corrected previous patch by changing dependency injection argument @entity.manager to @entity_type.manager for Drupal\field_tools\Routing\RouteSubscriber.

Pavan B S’s picture

Pavan B S commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly. Thanks for the patch

  • joachim committed 00094cf on 8.x-1.x authored by rocket.man 
    Issue #2858353 by rocket.man: Replaced use of deprecated entity.manager...
joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch and the review!

The admin.inc file is old D7 code that I'm keeping around in order to keep track of which functionality still needs porting, so I've left off the changes to that file. (I've added a notice to it too.)

Pavan B S’s picture

Pavan B S commented

@joachim, I guess you forgot to provide me RTBC credit, can you please do the needful.

joachim’s picture

joachim commented

Hi. I used the commit command suggested by the UI at the bottom of the issue, which only covers patches. Unfortunately, now that the commit's been made, I can't change the message on it, sorry.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.